236617 - Statically link JS

Status: RESOLVED FIXED

(Minimo Graveyard :: Build Config, defect)

Description

[Doug Turner (:dougt)]

Based on my investigation, we will save ~68k by statically linking JS.  lets-do-it!

Comment 1

[Brendan Eich [:brendan]]

I have no problem with this, but cc'ing bryner, who was working on gcc
visibility hacks to work around ELF PIC inefficiencies.

/be

Comment 2

[Doug Turner (:dougt)]

you might have problems with my current patch. :-)

Anyone remember the issue wrt why we don't statically link js in mozilla? 
something to do with xpinstall iirc.

Comment 3

[Benjamin Smedberg]

Statically link JS to what? the xpinstall stub installer would be fine if we
statically linked JS and XPCOM together into one meta-library (and we could link
NSPR as well).

We'd have to deal with backwards-compatibility crap, since a fair number of
extensions link against libmozjs.so/js3250.dll.

Comment 4

[Doug Turner (:dougt)]

aren't those extensions part of the bathwater and not the bath?

Comment 5

[Doug Turner (:dougt)]

err. baby.

Comment 6

[Benjamin Smedberg]

well... The JS APIs are technically frozen, as are NSPR. Does that mean we have
frozen the name of the DLL to link against? Darin and I discussed this WRT the
xpcom glue, and my efforts to not have the glue depend on NSPR (I'm almost done
with that patch, BTW).

Comment 7

[Travis Chase]

*** Bug 237575 has been marked as a duplicate of this bug. ***

Comment 8

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 9

[Benjamin Smedberg]

Comment on attachment 204564 [details] [diff] [review]
patch v.1

OK, this doesn't touch MOZ_JS_LIBS, so if somebody were to accidentally use this in a non-static build all hell would break loose.

So at least I'd like a check after --enable-js-static-build that it is only enabled along with --enable-static.

Something similar to http://lxr.mozilla.org/mozilla/source/configure.in#6174

Comment 10

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 11

[Doug Turner (:dougt)]

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1561; previous revision: 1.1560
done
Checking in js/src/Makefile.in;
/cvsroot/mozilla/js/src/Makefile.in,v  <--  Makefile.in
new revision: 3.96; previous revision: 3.95
done