236667 - 'Subscribe' menu item should be disabled/unavailable in more contexts

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Mike Cowperthwaite]

The 'Subscribe' menu item (File|Subscribe, in both 3pane and standalone windows, 
and in the folder and account context menus) is enabled, or available, in too 
many situations.  I suggest the following:
 3pane  File|Subscribe:  should be enabled only when a news or imap account, 
            or a newsgroup or imap folder, is selected.
 Standalone   File|Subscribe:  should be removed

 3pane Folder Context menus:  Subscribe should be removed
 3pane Account Context menus:  Subscribe should be available only for News and
            IMAP accounts, not for POP or Local Folders.

Comment 1

[Stefan Borggraefe]

Bug 92846 is a subset of this bug.

Comment 2

[Mike Cowperthwaite]

Moving my front-end RFEs from MailNews to Thunderbird (sorry for spam)

Comment 3

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 4

[Susurrus]

This is still a valid issue.

Also, I think that Subscribe should really be removed from the context menus for all folders and only exist for actual accounts. On a folder level, subscribe doesn't make sense.

Subscriptions should also be managed through the accounts manager primarily. I never even knew I could change the folder subscriptions for all my IMAP accounts! This is incredibly convenient and I never found it because it's not in the account settings, where I think this makes the most sense.

Comment 5

[:aceman]

Does this still exist? Can you summarize which items should be hidden and when?

Comment 6

[Mike Cowperthwaite]

Really?  Response 0 is insufficiently summarized for you?

Local Folders no longer has Subscribe in the context menu; that's the only improvement I see.
(That's the last of the four items itemized in the original bug description.)

Comment 7

[:aceman]

(In reply to Mike Cowperthwaite from comment #0)
> I suggest the following:
>  3pane  File|Subscribe:  should be enabled only when a news or imap account, 
>             or a newsgroup or imap folder, is selected.
Bug 92846.

>  3pane Folder Context menus:  Subscribe should be removed
Seems done.

>  3pane Account Context menus:  Subscribe should be available only for News
> and IMAP accounts, not for POP or Local Folders.
Seems done.

>  Standalone   File|Subscribe:  should be removed
Not sure. It also contains all the other "New" options.
Paenglab, what do you think about it?
Magnus, how can we determine if we are in the standalone message window?

Comment 8

[Magnus Melin [:mkmelin]]

(In reply to :aceman from comment #7)
> >  3pane Folder Context menus:  Subscribe should be removed
> Seems done.

Still there.

> Magnus, how can we determine if we are in the standalone message window?

If we're messageWindow.xul

Comment 9

[:aceman]

(In reply to Magnus Melin from comment #8)
> (In reply to :aceman from comment #7)
> > >  3pane Folder Context menus:  Subscribe should be removed
> > Seems done.
> Still there.
Where? On folders in which account types?

Comment 10

[Richard Marti (:Paenglab)]

In standalone window it should be removed.

It is shown no matter if the message is from a POP or a IMAP account. And it makes no sense to have this item in a message.

Comment 11

[Magnus Melin [:mkmelin]]

(In reply to :aceman from comment #9)
> Where? On folders in which account types?

For imap, nntp and feeds. Right click a folder and it's 4th from the top.

Comment 12

[:aceman]

And that is bad? Should they only be on the account nodes?

Comment 13

[Richard Marti (:Paenglab)]

When you're on a folder, you are already subscribed. Then the subscribe item makes not much sense (NNTP has also a unsubscribe on folder and this makes sense). For new subscriptions it's better to do this on the account.

Comment 14

[:aceman]

(In reply to Richard Marti (:Paenglab) from comment #10)
> In standalone window it should be removed.

OK, but with bug 92846 the item is disabled, becase messageWindow does not support the new command. Probably that is why I saw it was already done.

Comment 15

[Richard Marti (:Paenglab)]

(In reply to :aceman from comment #14)
> (In reply to Richard Marti (:Paenglab) from comment #10)
> > In standalone window it should be removed.
> 
> OK, but with bug 92846 the item is disabled, becase messageWindow does not
> support the new command. Probably that is why I saw it was already done.

It's always disabled or only on POP messages? It should be always be disabled.

Comment 16

[:aceman]

Seems always, also on RSS and News message.

Comment 17

[:aceman]

Attachment: patch

So please try this, together with the patch in the other bug.
It seems NNTP accounts and "folders" (newsgroups) also have a Unsubscribe menuitem, so Subscribe can be also hidden on them and shown only on the account, as you specified.

Comment 18

[Richard Marti (:Paenglab)]

Comment on attachment 8666176 [details] [diff] [review]
patch

(In reply to :aceman from comment #17)
> Created attachment 8666176 [details] [diff] [review]
> patch
> 
> So please try this, together with the patch in the other bug.
> It seems NNTP accounts and "folders" (newsgroups) also have a Unsubscribe
> menuitem, so Subscribe can be also hidden on them and shown only on the
> account, as you specified.

This looks good. The items are removed/disabled where it should be together with the other bug.

The "Unsubscribe" can stay how it is as it acts per newsgroup.

Comment 19

[:aceman]

Thanks.

Comment 20

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/e2a40f305d0026812af60ad9d95eb88e355064c3
Bug 236667 - hide 'Subscribe...' context menu item when not on an account of the proper server type. ui-r=Paenglab, r=mkmelin

Comment 21

[alta88]

What possible reason is there to remove Subscribe from feed folders?  This is a complete usability regression, as the dialog was designed to open with the right click folder selected and opened so feed subscriptions could be quickly adjusted.  Now, the desired folder and its subscriptions have to be hunted down with multiple clicks in the tree.

The docs even describe this way of getting to subs fast. This must be reverted for feeds.

Comment 22

[Magnus Melin [:mkmelin]]

Yeah didn't think of that.