text-decoration: blink: it's impossible to turn off, or on via DOM

RESOLVED FIXED in mozilla1.8alpha1

Status

()

Core
DOM: CSS Object Model
P3
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Gyuris Gellért, Assigned: bz)

Tracking

({testcase})

Trunk
mozilla1.8alpha1
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; hu-HU; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; hu-HU; rv:1.6) Gecko/20040206 Firefox/0.8

it's impossible to turn off, or on via DOM

Reproducible: Always
Steps to Reproduce:
1. switch text-decoration 
2.
3.
(Reporter)

Comment 1

14 years ago
Created attachment 143369 [details]
testcase

Updated

14 years ago
Keywords: testcase

Comment 2

14 years ago
See also bug 179079 (might be related, but does not involve scripting).

Comment 3

14 years ago
(In reply to comment #2)
> See also bug 179079 (might be related, but does not involve scripting).

Last testcase does
Probably an issue with the textframes not killing off the blink timer... The
problem is that text frames are added to and removed from the blink timer in
reflow, but changing text-decoration only does a repaint....
Come to think of it, can text-decoration affect line-box sizing?  If so, could
it need reflow anyway?
I wouldn't have thought they could affect line-box sizing.

I don't see a problem with making text-decoration just do a reflow. It's
unlikely to be performance critical.
I'd rather not make text-decoration changes reflow.  changing text-decoration on
:hover (for links) is not uncommon.
The other option is to reflow only if the "blink" bit changed....  That should
happen about once in a blue moon.
Created attachment 147476 [details] [diff] [review]
Like so

Though really, maybe we should just remove blink....
Attachment #147476 - Flags: superreview+
Attachment #147476 - Flags: review+
(This fixes turning off too?)
> (This fixes turning off too?)

Yep.  Fixes all testcases in this bug and in bug 179079.  Taking, I guess.
Assignee: general → bzbarsky
Blocks: 179079
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha
Checked in for 1.8a.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.