236913 - Colon in search show in sidebar as %3A

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Richard van den Berg]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

When using the Search Sidebar, a colon (:) inside the search is escaped to %3A
which make pressing the "Search" button to perform another search. In Mozilla
1.5 and below the colons were not escaped, and pressing the "Search" button gave
exactly the same results.

Reproducible: Always
Steps to Reproduce:
1. Using the Siderbar, search (using Google) for "site:mozilla.org search"
2. The Search Sidebar will say: "site%3Amozilla.org search"
3. Click the Siderbar's "Search" button
4. The found results will differ from step 1

Actual Results:  
A different search is performed

Expected Results:  
The same search should be performed

Comment 1

[Richard van den Berg]

I just upgraded to Mozilla 1.7 (Linux version). This problem is still there! Can
someone please test this so that the status can be set to NEW?

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[[e-mail]]

Comment on attachment 151096 [details] [diff] [review]
Proposed patch

More bug 44272 fallout... note that jshin used encodeURIComponent in the same
file in the same patch :-(

Comment 4

[Alec Flett]

Comment on attachment 151096 [details] [diff] [review]
Proposed patch

doh. sr=alecf

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[[e-mail]]

Really marking fixed :-[

Comment 7

[[e-mail]]

*** Bug 285021 has been marked as a duplicate of this bug. ***