236940 - support off-line in Chatzilla

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[u85353]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040219
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040219

After going offline through Navigator or MailNews, ChatZilla disconnects without
telling you. ChatZilla is unable to reconnect to the same IRC server/network
without closing and reloading ChatZilla.

Also does this with Mozilla 1.7a Linux.

Reproducible: Always
Steps to Reproduce:
1. Click the blue "Work Online"/"Work Offline" toggle at the bottom right corner
of the Navigator or MailNews window.

Actual Results:  
No notification in ChatZilla of being offline, messages do not go through.
Cannot reconnect to the same IRC server/network without closing and restarting
ChatZilla.

Expected Results:  
Notify user of disconnect, allow reconnect.

[INFO]	Chatzilla 0.9.59 [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.7a) Gecko/20040219]

Same version under Linux, I think.

Comment 1

[u85353]

sorry, let me rewrite this:

After going offline through Navigator or MailNews, ChatZilla disconnects without
telling you. ChatZilla is unable to reconnect to the same IRC server/network
without closing and reloading ChatZilla AFTER WORKING ONLINE AGAIN.

Actual Results:  
No notification in ChatZilla of being offline, messages do not go through.
Cannot reconnect to the same IRC server/network AFTER WORKING ONLINE AGAIN
without closing and restarting ChatZilla.

Expected Results:  
Notify user of disconnect, allow reconnect AFTER GOING BACK ONLINE.

Comment 2

[Sean Umphlet (nosebleed)]

Confirming

Comment 3

[Alex Hirzel]

Seen in Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219

Adding helpwanted.

Comment 4

[Alex Hirzel]

*** Bug 166929 has been marked as a duplicate of this bug. ***

Comment 5

[Alex Hirzel]

Changing the summary to better reflect the issue described by this and bug 166929.

Comment 6

[Samuel Sieb]

If you use the /disconnect command, you can reconnect without restarting.

Comment 7

[James Ross]

I seem to remember that the problem here is Offline Mode being a horrible mess,
and completely fails to notify anyone when it disconnects things. I believe if
oy're off-line and try to connect (even from a clean start) ChatZilla gets no
connection (obviously) *AND* no exception/error from the connection.

Comment 8

[benc]

-> all,all.

Comment 9

[James Ross]

Ok, we've seen some small improvement here - in ChatZilla 0.9.66e (I honestly
don't remember which version I added it in, but it was after 0.9.66), if a
connection is attempted when in off-line mode, the error is caught and the
following message is displayed:

The host software platform (e.g. Mozilla, Firefox) is in ``offline mode''. No
network connections can be made in this mode.

Comment 10

[Samuel Sieb]

Other than the offline icon which is bug 166929, isn't this bug fixed?

Comment 11

[James Ross]

I believe we still choke if off-line is enabled when connected. When this happens, an exception is thrown somewhere totally weird, as I recall, and we don't catch it, instead just breaking the event loop or something (though that bit is likely fixed by other work).

Comment 12

[:Gijs (he/him)]

This is fixed by my patch on bug 166929, afaict.

Comment 13

[:Gijs (he/him)]

And then it was no longer fixed by the latest patch. Note that on builds before 2003-01-17 and after 2004-08-04, there should be no problem after fixing bug 166929. For all the other builds (notably Moz 1.4, 1.7 and Firefox 1.0), we still need a (complicated) solution. I'll try to hack on it here.

Comment 14

[:Gijs (he/him)]

I'm not working on this anymore, and to be honest I don't think it's worth doing so anymore anyway. It works on recent versions, and that's good enough for me.

Comment 15

[James Ross]

We should reconnect when you go back online, but that's bug 475070 so this one's done.