Closed Bug 236971 Opened 21 years ago Closed 20 years ago

tigris.org - back button does not restore scroll position on tigris.org pages

Categories

(Tech Evangelism Graveyard :: English US, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED WORKSFORME

People

(Reporter: bmo, Unassigned)

References

(Blocks 1 open bug, )

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113 like bug 217120, the back button doesn't work as expected. if you have scrolled down on a page like http://subversion.tigris.org/project_links.html and click a link and then click the back button to go back, you end up back at the top of the page instead of where you were before you clicked the link. this reproduces for me on multiple machines with both firefox and mozilla. Reproducible: Always Steps to Reproduce:
A minimal HTMl page that shows the problem would be very nice here....
Keywords: qawanted
Obviously this has something to do with JavaScript, because disabling JS gets rid of this problem..
This is a side effect of document.loginform.loginID.focus() right? This is in the function loginfocus() which is set to run onload.
Mmmm, yes. When a form control is focused it's automatically scrolled into view, so that the user doesn't accidentally type in invisible form controls if nothing else. Thanks for catching that!
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago
Resolution: --- → INVALID
the bug isn't invalid. you're just claiming that it isn't the fault of mozilla code. is there a way to turn off this feature in mozilla? if not, i'll file an additional RFE.
Status: RESOLVED → UNCONFIRMED
Component: History: Session → English US
Product: Browser → Tech Evangelism
Resolution: INVALID → ---
Version: Trunk → unspecified
You can always disable focus() calls via CAPS.
(In reply to comment #6) > You can always disable focus() calls via CAPS. if you don't mind the exception that this throws.
also, it would be nice if the auto-scroll were only disabled when travelling through history. filed bug 240511 with feature request.
for this bug, filed tigris.org wwww issue 65. http://www.tigris.org/issues/show_bug.cgi?id=65
Depends on: 251784
Blocks: 251784
No longer depends on: 251784
Summary: back button does not restore scroll position on tigris.org pages → tigris.org - back button does not restore scroll position on tigris.org pages
WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0 Reporter, please test a current build and tell us if it is still a problem. Otherwise we could resolve this bug.
i can no longer repro this on old or new builds, but it looks like this is due to a bug in tigris.org code, not by design. project_links.html still contains: === <script src="/branding/scripts/tigris.js" type="text/javascript"></script> === tigris.js still contains: === // Focus on user name input (the "loginform.loginID" field). function loginfocus() { if (document.loginform) { document.loginform.loginID.focus(); } } === project_links.html still calls loginfocus() onload, but they changed the name of the form from "loginform" to "bannerloginform" so it no longer behaves as designed and the focus change never happens. i guess we can close this tech evangelism bug, in any case.
Assignee: nobody → english-us
QA Contact: history.session → english-us
> i guess we can close this tech evangelism bug, in any case. Could someone close this bug if as it no longer applies and there is another bug (see Bug 240511) which specifically covers the focus/onload issue? I would mark as WFM but I don't yet have privs to do so. Thanks Dan
works for me.
Status: UNCONFIRMED → RESOLVED
Closed: 21 years ago20 years ago
Resolution: --- → WORKSFORME
v.
Status: RESOLVED → VERIFIED
Keywords: qawanted
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.