236980 - Pref panel respec for Cookies prefs

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect, P1)

Description

[Mike Connor [:mconnor]]

Bug 233339 changed the world of cookie prefs and finally unforked the final two
prefs that were #ifdef'd MOZ_PHOENIX.  Now we just need to look at the pref
panel and make something a little more clear and a little less ugly.

firebird.js needs to be updated too (didn't get to that part yet, the migration
code will kill the prefs spawned from there on startup, I intend to fix this
within a week at most, and hopefully sooner)

Comment 1

[HJ]

Why doesn't the 'Block cookies' radio disable the 'Cookie Lifetime Policy'
settings? We can now setup: 'Block cookies' and 'Accept cookies normally' and
that can't be right!

Can you please replace 'Accept cookies normally' with something like 'Use
expiration set by cookies' or 'Use expiration specified by cookies'. There's
nothing 'abnormal' about changing the lifetime of cookies.

Can you change:
  (.) Allow cookies based on your Privacy Settings [_V_iew]
into:
  (.) Allow cookies based on your [_P_rivacy Settings] 

Using 'View' for the button is not right, because you can also modify your settings.

What is the purpose of: network.cookie.alwaysAcceptSessionCookies and  
pref.advanced.cookies.disable_button.more_info ?

Can you change for="lifetimeDays" into control="lifetimeDays", because clicking
on 'days' now won't select the 3th radio, as it should.

Why did you remove 'Ask for each cookie' from 'Cookie Acceptance Policy'?
What exactly is 'Ask for each cookie' now?

Comment 2

[Mike Connor [:mconnor]]

HJ: this isn't the right bug for these comments, this is Firefox, not 
Seamonkey.  If you want to complain about the UI in Seamonkey, file a seamonkey 
bug against me.

Comment 3

[HJ]

(In reply to comment #2)
> HJ: this isn't the right bug for these comments, this is Firefox, not 
> Seamonkey.  If you want to complain about the UI in Seamonkey, file a seamonkey 
> bug against me.

<embarrassed>Doh, I got this bugnumber from Neil, and didn't check the product.
Sorry for my questions</embarrassed>

Comment 4

[HJ]

Done, see bug 238554

Comment 5

[Mike Connor [:mconnor]]

Attachment: proposal #1

First real crack at this

Comment 6

[Mike Connor [:mconnor]]

Ben's planned UI for this is good enough for me :)

Comment 7

[alanjstr]

Did you want to point us to that, or just leave us guessing?

Comment 8

[Mike Connor [:mconnor]]

I can leave you guessing, or ask me later on IRC

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change