Last Comment Bug 237042 - optimize nsRuleNode::GetStyleData
: optimize nsRuleNode::GetStyleData
Status: RESOLVED FIXED
[patch]
: perf
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: mozilla1.7beta
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
: Hixie (not reading bugmail)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-03-10 11:18 PST by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2014-04-26 03:09 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.89 KB, patch)
2004-03-10 11:19 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
bzbarsky: superreview+
chofmann: approval1.7b+
Details | Diff | Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-03-10 11:18:51 PST
There are a few things that could speed up nsRuleNode::GetStyleData and
GetParentData:
 * NS_LIKELY / NS_UNLIKELY (for modern gcc with -O2)
 * using dependent bits checks more and cached style data checks less (since the
two should be equivalent in many ways)
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-03-10 11:19:29 PST
Created attachment 143527 [details] [diff] [review]
patch
Comment 2 Boris Zbarsky [:bz] (Out June 25-July 6) 2004-03-10 11:37:07 PST
Comment on attachment 143527 [details] [diff] [review]
patch

r+sr=bzbarsky
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-03-10 13:13:27 PST
Comment on attachment 143527 [details] [diff] [review]
patch

This should be pretty low risk since if it breaks anything, it should break
pretty much everything.
Comment 4 chris hofmann 2004-03-11 20:20:31 PST
Comment on attachment 143527 [details] [diff] [review]
patch

a=chofmann for 1.7a
Comment 5 chris hofmann 2004-03-11 20:20:53 PST
er, 1.7b
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-03-14 09:46:37 PST
Fix checked in to trunk, 2004-03-14 09:11 -0800.

Note You need to log in before you can comment on or make changes to this bug.