optimize nsRuleNode::GetStyleData

RESOLVED FIXED in mozilla1.7beta

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
13 years ago
3 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({perf})

Trunk
mozilla1.7beta
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
There are a few things that could speed up nsRuleNode::GetStyleData and
GetParentData:
 * NS_LIKELY / NS_UNLIKELY (for modern gcc with -O2)
 * using dependent bits checks more and cached style data checks less (since the
two should be equivalent in many ways)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7beta
(Assignee)

Comment 1

13 years ago
Created attachment 143527 [details] [diff] [review]
patch
(Assignee)

Updated

13 years ago
Attachment #143527 - Flags: superreview?(bzbarsky)
Attachment #143527 - Flags: review?(bzbarsky)
Comment on attachment 143527 [details] [diff] [review]
patch

r+sr=bzbarsky
Attachment #143527 - Flags: superreview?(bzbarsky)
Attachment #143527 - Flags: superreview+
Attachment #143527 - Flags: review?(bzbarsky)
Attachment #143527 - Flags: review+
(Assignee)

Comment 3

13 years ago
Comment on attachment 143527 [details] [diff] [review]
patch

This should be pretty low risk since if it breaks anything, it should break
pretty much everything.
Attachment #143527 - Flags: approval1.7b?

Comment 4

13 years ago
Comment on attachment 143527 [details] [diff] [review]
patch

a=chofmann for 1.7a
Attachment #143527 - Flags: approval1.7b? → approval1.7b+

Comment 5

13 years ago
er, 1.7b
(Assignee)

Comment 6

13 years ago
Fix checked in to trunk, 2004-03-14 09:11 -0800.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.