237191 - Use NS_UNLIKELY for checking allocation failures

Status: RESOLVED INCOMPLETE

(SeaMonkey :: General, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

I wrote a small perl script to find a few common allocation patterns and the
subsequent failure check, and wrap that check in an NS_UNLIKELY.  There were a
few changes I had to make, but they are minimal.  I've been using this build for
about an hour now without any problems.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: perl script

I ran this with `find -name "*.cpp" | xargs perl -i mkunlikely`

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch (tar.bz2)

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 143672 [details]
Patch (tar.bz2)

r+sr=me based on my reading of the perl script and checking selected parts of
the patch.

Comment 4

[Frank Wein [:mcsmurf]]

Was this patch here ever checked in (does not seem so)? Probably a new patch is needed so if this should be checked in.

Comment 5

[Tony Mechelynck [:tonymec]]

No reply to comment #4 => INCOMPLETE