237204 - pressing enter on the bookmarks manager search field clears the display of all bookmarks

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Tauhida Parveen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040210 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040210 Firefox/0.8

In the bookmark manager window ( from the manage bookmark option, when the
search input box is selected and enter is pressed without entering any text to
search for  all the existing bookmarks disappears and the only way the window
can be refreshed is by closeing the window. 

This happens only if enter is pressed without typing any string to search for in
the search window. If a string is entered and is search for first and then enter
is pressed without any text in the search input box, this bug does not appear.

This feture was tested on Windows XP, Firefox 0.8


Reproducible: Always
Steps to Reproduce:
1. Start Firfox 0.8
2. Select Bookmark from the toolbar and select Bookmarks Manager
3. Select the search input box but do not type any text and press enter 

Actual Results:  
All the bookmarks disappear and the bookmark manager window needs to be closed
in order to see the existing bookmarks again.

Expected Results:  
Should keep all the bookmark and should show a pop-up message indicating that
there were no text entered to search on.

Comment 1

[Mike Connor [:mconnor]]

dialogs are bad except in extreme cases (dataloss, etc).  Otherwise they get
ignored (they probably do anyway).  Read the GNOME HIG for a good rationale
behind this.  We should show the full list/reset when the search bar is empty
though, which is true.  See the thunderbird mail search for an example of what
we should do here.

Comment 2

[Cem Kaner]

(In reply to comment #1)

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040403
Firefox/0.8.0+

I get the same behavior on the Mac. I agree that it would be better to repaint
the  full list of bookmarks than to post an error message.

Comment 3

[u102922]

This happens because the window is bad designed.
It must have a separate result panel different than the list of bookmarks.
I recommend removing the search feature for the moment, if no further
development is planned.

Comment 4

[Asa Dotzler [:asa]]

This is another fairly serious problem with the bookmarks manager. If we can't
fix this and the broken menus/buttons, we should disable this feature for 1.0 

I confirmed this behavior with the latest branch firefox build. The bookmarks
sidebar suffers from the same problem.

Comment 5

[logan]

Confirmed on linux as well. OS -> All

Comment 6

[logan]

Attachment: bookmarksTree.xml patch v1

I'm not 100% on this, but it fixes the problem for me.

Comment 7

[Robert Parenton]

Comment on attachment 154135 [details] [diff] [review]
bookmarksTree.xml patch v1

Moving review request to a person.  FYI, you have to request review from a
person instead of just setting the review? flag.

Comment 8

[Ian Pottinger]

> I'm saying that anyone who does is not competitive.  There are fewer offenders now
> than in the dark days of Netscape 6 -- but the old offenses hang around too
often, 
> without owners.  Bob may have data here.

A curious statement.  As a web developer, I’ve been very intrigued by this
development.  Im very tempted to simplify my code by eliminating the
.getElementById forks and just use .layer and .all.  This will definitely save
me coding, debugging and testing time.

Comment 9

[Ian Pottinger]

please disregard my previous comment.  wrong bug. :-(

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 154135 [details] [diff] [review]
bookmarksTree.xml patch v1

a=[e-mail]

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

In on aviary, thanks!

Comment 12

[Tracy Walker [:tracy]]

verified fixed as seen on Windows 2004-10-07-06-0.9 and Mac 2004-10-07-05-0.9

Comment 13

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change