User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.6) Gecko/20040206 Firefox/0.8 Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.6) Gecko/20040206 Firefox/0.8 A user can create a null location bookmark without a warning message. After the bookmark is created if it is attempted to be used no action results (page opens, error message, etc.) except the Bookmarks menu drop down window losses focus. To an inexperienced user this may appear as though there is something is wrong with the browser or the requested site or path. By adding an warning message the browsers user friendliness could be enhanced. An example of this is a bookmark that was inadvertently created with a Null Entry by a more experienced user for a less experienced user. I compared the above-described behavior to that of Internet Explorer version 5.50.4807.2300CO. The design is slightly different, but a similar function (bookmark Properties) within IE with a location input field (URL: in IE) does provide the user an error message if a Null Entry is entered into the URL field. Step to replicate Null Entry error message in Internet Explorer: Favorites à Right Click on any website --> Select Properties --> Switch to the Web Documents tab in the Properties Dialog Box --> Delete the entry in the URL field --> Click OK. Reproducible: Always Steps to Reproduce: 1. Bookmarks --> Manage Bookmarks --> New Bookmark 2. Click OK on the Properties of “New Bookmark” dialog box. Actual Results: A warning message was not displayed that the user created a bookmark with a Null Entry in the location field. Expected Results: A message box warning that a location was not entered into the bookmark's location field (info tab).
dialogs are a lazy way of doing things. A better method would be to simply disable the OK button and block dialog acceptance unless valid entries are present. We could even go as far as to parse the location to be a valid URI when enabling/disabling the ability to submit. Since this is an application-modal dialog, perf isn't a huge issue.
Severity: enhancement → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Null Entry in the location input field does not trigger a warning message → Bookmarks can be created without a valid location
mconnor: if I type "google.com" or "htp://google.com" and then find the "OK" button disabled, I'm not going to think "Oh, maybe I typed an invalid URL". I'm going to think "WTF is the OK button disabled?" I think an error dialog is appropriate here. (Btw, we're really talking about bug 237208; this bug is just about the case where the Location field is empty.)
meaning a dialog if there's an invalid URI, or if its blank? I think disabling OK until there's a value in the textbox is enough of a fix. nsIURI won't really pick up on links to local hostnames unless we try to connect, so trying to validate won't work anyway. If people bookmark the wrong address, they'll realize when they get "foo could not be found"
Disabling the OK button while the location field is empty is ok.
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
The Add button (no longer called OK) is disabled now until you have something there, so this is WORKSFORME on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b3pre) Gecko/20081210 Shiretoko/3.1b3pre
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.