Closed Bug 237213 Opened 20 years ago Closed 20 years ago

[FIXr]Replace nodetype check with IsContentOfType in nsContentList

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8alpha1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file, 1 obsolete file)

Patch updated to comments
1.98 KB, patch
Details | Diff | Splinter Review 
The two should be equivalent, and the latter is faster and less code.
Attached patch Patch (obsolete) — — Splinter Review 

    
  

        Attachment #143681 -
        Flags: superreview?(jst)

        Attachment #143681 -
        Flags: review?(jst)

    
    

    
  
Comment on attachment 143681 [details] [diff] [review]
Patch

+    if (!aContent->IsContentOfType(nsIContent::eELEMENT)) {
       return PR_FALSE;
+    }

+    nsINodeInfo *ni = aContent->GetNodeInfo();
+    if (!ni) {
+      NS_ERROR("Element without nodeinfo!");
       return PR_FALSE;

This is not needed any more then, all elements have nodeinfo, if they don't,
they're broke and should be fixed.

r+sr=jst with that unnecessary check removed.

        Attachment #143681 -
        Flags: superreview?(jst)

        Attachment #143681 -
        Flags: superreview+

        Attachment #143681 -
        Flags: review?(jst)

        Attachment #143681 -
        Flags: review+

    
  
Priority: -- → P2
Summary: Replace nodetype check with IsContentOfType in nsContentList → [FIXr]Replace nodetype check with IsContentOfType in nsContentList
Target Milestone: --- → mozilla1.8alpha

    
    

    
  


  

        Attachment #143681 -
        Attachment is obsolete: true

    
    

    
  
Fix checked in for 1.8a.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
  
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general

          You need to log in
          before you can comment on or make changes to this bug.