237332 - css is ignored, when "Every time I view the page" is checked.

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[matsuba]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7b) Gecko/20040312 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040312

css is ignored. when "Every time I view the page" is checked.


Reproducible: Always
Steps to Reproduce:
1. install mozilla-i686-pc-linux-gnu-2004-03-12-09-trunk.tar.gz
2. Mozill start.
3. Go http://www33.ocn.ne.jp/~snip/mozilla/, loading css is ok.
4. Edit -> Preferences -> Advanced -> Cache,
  Select "Every time I view the page" and applies by using [OK],
5. Push "reload", css is ignored.

6. Edit -> Preferences -> Advanced -> Cache,
  Select "When the page is out of date" and applies by using [OK],
7. Push "Reload", css is loaded correctly.




2004-03-05-09-trunk: OK
2004-03-06-10-trunk: OK
2004-03-08-10-trunk: OK

From 2004-03-09-09-trunk: NG

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 232385 

When loading the page with that cache setting, I get two instances of:

WARNING: NS_ENSURE_TRUE(mCachedResponseHead) failed, file
/home/bzbarsky/mozilla/xlib/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,
line 1041

The site is loading the same sheet from each of the three frames.

My guess is that what happens is that the first frame starts the sheet load and
then the other two frames fail to get write access to the cache entry or
something when they try to do the same, since the first load is still in
progress.  Now the content in the cache entry is _not_ valid (since we have the
"recheck with server every time" flag set).  So we don't just ReadFromCache(). 
But we only got read access to the cache, so we CloseCacheEntry(), which blows
away our mCachedResponseHead.  Once that's null, we bail out of
ProcessNotModified with the warning I pasted above...

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for backing out bug 232385, as requested in email to drivers

Comment 3

[Darin Fisher]

fixed by backing out my patch for bug 232385.

Comment 4

[matsuba]

My build from cvs on Mon Mar 15 16:15 JST 2004:
Verified Fixed.

Build 2004-03-14-09-trunk: Linux
It appears to not be working now on linux.