Closed Bug 237376 Opened 16 years ago Closed 9 years ago

Put 'reply to newsgroup' on top

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a3

People

(Reporter: u81239, Assigned: shehab.elnoury)

References

Details

(Whiteboard: [patchlove])

Attachments

(1 file, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Hi,

In Mozilla, when right-clicking on a newsgroup message in order to reply, the
option 'reply to sender only' is first listed in the context menu, and 'reply to
newsgroup' second. I think that it would be much more logical if this were the
other way around (I at least keep accidentally clicking on the wrong one)...
After all, most replies on a newsgroup are sent to the newsgroup itself, and
aside from that, many people use fake email addresses because of spam bots, so
often sending an email is not even possible. Therefore, in my opinion, the
'reply to newsgroup' item should be the top one. I hope everyone agrees.

I also think 'reply to sender' should be enough, there's no need to put the
'only' after it. But ahwell, I don't particularly care for that.


~Grauw

Reproducible: Always
Steps to Reproduce:
1. Go to newsgroup
2. Right-click on message
Actual Results:  
Shows (in this order):
Reply to Sender Only, Reply to Newsgroup, Reply to All

Expected Results:  
Reply to Newsgroup, Reply to Sender Only, Reply to All
xref bug 236833.
Severity: trivial → enhancement
This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/
The problem is still there, and I still think it would be a good idea to fix this.

A simple ‘yes this is a good idea’ or ‘no we don’t agree’ from the people
involved with the Thunderbird UI design would be sufficient to decide whether to
either confirm this and keep it on the radar to fix, or resolve this as WONTFIX.


~Grauw
Yes, I would also like to see this one resolved, and it's probably a quick fix
(reorder a couple of lines of code) should someone decide to do something about it.
Here’s a patch.
QA Contact: front-end
Assignee: mscott → nobody
Has a patch.
Needs Review

Added CC: vseerror@lehigh.edu
While I'm not involved in the development of Thunderbird I am a developer, but even if I weren't I would say that the patch looks fine. The big question is whether it is up to date, considering it's been more than 3 years since it was submitted.
While this bug has an offered patch, it needs review for bitrot and UI decision for whether it will be taken.

Added CC: clarkbw@gnome.org for UI decision
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: helpwanted
Whiteboard: [patchlove]
Version: unspecified → 1.0
Mail sent to patch author.
Mail to patch author bounced from the university He was a student of. If We want this any follow up will need a new assignee.
Seems like a logical move to me.  If our assumption is that reply to newsgroup is the best default option we should be placing that above (with greater prominence) to other options.
(In reply to comment #11)
> Seems like a logical move to me.  If our assumption is that reply to newsgroup
> is the best default option we should be placing that above (with greater
> prominence) to other options.

To me the RFE is asking for a 'Conditional' swap of Sender and News reply in the menus. 

I think the conditional swap is smarter, as reply to News is the default news reply mode, not sender only. Long term a smarter UX would be even better.
exactly, I think we are in agreement
Comment on attachment 197624 [details] [diff] [review]
Patch which moves reply to sender below reply to newsgroup

Patch has bitrotted.

$ patch --dry-run < ~/Desktop/tbTestPatches/237376.diff 
(Stripping trailing CRs from patch.)
patching file mailWindowOverlay.xul
Hunk #1 FAILED at 426.
Hunk #2 FAILED at 763.
2 out of 2 hunks FAILED -- saving rejects to file mailWindowOverlay.xul.rej
Attachment #197624 - Attachment is obsolete: true
What was required was to change the order when the message was right clicked on, but for consistency, I also changed the order in the main message tab at the top.
Attachment #421961 - Flags: review?(bienvenu)
Comment on attachment 421961 [details] [diff] [review]
Attachment is a patch that puts reply to news group before reply to sender. Both when right clicked on the actual message, and from the message drop down list.

asking for ui review, switching review request to Magnus
Attachment #421961 - Flags: ui-review?(clarkbw)
Attachment #421961 - Flags: review?(mkmelin+mozilla)
Attachment #421961 - Flags: review?(bienvenu)
Assignee: nobody → shehab.elnoury
Status: NEW → ASSIGNED
Comment on attachment 421961 [details] [diff] [review]
Attachment is a patch that puts reply to news group before reply to sender. Both when right clicked on the actual message, and from the message drop down list.

This patch doesn't apply. Looks like it might work though. Please generate your patch using "hg diff" 

Please note that mozilla style is "no tabs", use spaces instead, and fix the alignments
Attachment #421961 - Flags: review?(mkmelin+mozilla)
Attachment #422138 - Flags: ui-review?(clarkbw)
Attachment #422138 - Flags: review?(mkmelin+mozilla)
(In reply to comment #17)
> (From update of attachment 421961 [details] [diff] [review])
> This patch doesn't apply. Looks like it might work though. Please generate your
> patch using "hg diff" 
> 
> Please note that mozilla style is "no tabs", use spaces instead, and fix the
> alignments

Can you please give me the hg diff command that I should be using for this patch?
Use "hg diff > ../bug237376.patch" and attach the file bug237376.patch to this bug. https://bugzilla.mozilla.org/attachment.cgi?id=422138 doesn't apply either, it says

patching file mail/base/content/mailWindowOverlay.xul
patch: **** missing line number at line 4: @@ -614,-16 +614,-12 @@

Are you somehow hand editing the diff file? If you are, you shouldn't. 
Once you have generated your patch file, try it locally: 
hg import --no-commit ../bug237376.patch 
should work
Comment on attachment 422138 [details] [diff] [review]
Same as previous attachment but with alignment and tab fixes.

Minusing as this doesn't apply.
Attachment #422138 - Flags: review?(mkmelin+mozilla) → review-
Attachment #421961 - Flags: ui-review?(clarkbw)
Comment on attachment 422138 [details] [diff] [review]
Same as previous attachment but with alignment and tab fixes.

I'm guessing it's this one.  Either way the idea here seems good to me.  If we're looking at a newsgroup then reply to newsgroup should be the top result.
Attachment #422138 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 421961 [details] [diff] [review]
Attachment is a patch that puts reply to news group before reply to sender. Both when right clicked on the actual message, and from the message drop down list.

As indicated, this patch has been superceded.
Attachment #421961 - Attachment is obsolete: true
From Shehab ElNoury's patch.

Bringing over ui-review+.
Attachment #422138 - Attachment is obsolete: true
Attachment #506318 - Flags: ui-review+
Attachment #506318 - Flags: review?(mkmelin+mozilla)
Attachment #506318 - Flags: review?(mkmelin+mozilla) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/271d9591cf36
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: helpwanted
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
Whiteboard: [patchlove]
Whiteboard: [patchlove]
You need to log in before you can comment on or make changes to this bug.