237382 - Help instructions for importing bookmarks are incorrect

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Elton F. Jackson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla 1.6 / 5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113

Using a new Dell Windows XP desktop (Machine A), running Mozilla 1.6, I am
trying to import booksmarks from Mozilla 1.6 running on a Dell Windows XP laptop
computer (Machine B).  I got the help section on "Exporting or Importing a
Bookmark List".  The instructions on exporting bookmarks work just fine.  I
successfully exported booksmarks from my Machine B into a file called
"bookmarks.html" on a CD.

Then I tried to follow the instructions for IMPORTING bookmarks.  Working on
Machine A, I opened the Mozilla 1.6 bookmarks menu and clicked on Manage
Bookmarks.  I then clicked on Tools, then Import.  In the "Import bookmark file"
dialog box, I browsed my CD and selected the "bookmarks.html" file.

The instructions then say "4.  Click Save".  But there is NO SAVE BUTTON to
click.  There's only an "Open" button and when I click on it, it appears to
simply add booksmarks that duplicate those already on Machine A.  No bookmarks
are imported from the "bookmarks.html" file.

Reproducible: Always
Steps to Reproduce:
1.  Click on Bookmarks, then Manage Bookmarks.
2.  Click on Tools, then Import.  Select (highlight) the name of the file with
the bookmarks to be imported.
3.  Try to follow the instructions to "Click Save".  There is no Save button.

Actual Results:  
Seeing only an "OPEN" button, I clicked on it.  It seems to just add dublicate
bookmarks, duplicates of those already on my computer.  No new bookmarks are
imported.

Expected Results:  
Shown a "Save" button on the "Import bookmark file" page.  When this (missing)
button is clicked, Mozilla should add bookmarks from the import file to those
already existing on the machine.

Comment 1

[R.J. Keller]

Bug confirmed 20040313 (a bit old, but should still be valid for this kind of bug)

Comment 2

[Stefan [:stefanh]]

> Seeing only an "OPEN" button, I clicked on it.  It seems to just add dublicate
> bookmarks, duplicates of those already on my computer.  No new bookmarks are
> imported.

Mozilla 2004040505, Mac OS 10.2.8
Importing bookmarks works fine for me if i follow the instructions and hit
"Open" (instead of the missing "Save" button). 

Comment 3

[Stefan [:stefanh]]

Attachment: Simple patch, Save --> Open

AFAIK, the only problem is that the name of the button has changed. This simple
patch updates the help text.

Comment 4

[R.J. Keller]

Fix checked in.