Closed Bug 237437 Opened 20 years ago Closed 20 years ago

In <abDragDrop.js>, "2" "Warning: anonymous function does not always return a value"

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Product:
SeaMonkey
Component:
MailNews: Address Book & Contacts
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.7final

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

Attachments

(3 obsolete files) 

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040219] (W98SE)

{{
Warning: anonymous function does not always return a value
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 132, Column: 16
Source Code:
          return; // should not be here

Warning: anonymous function does not always return a value
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 175, Column: 4
Source Code:
    },
}}

Updating:
*(A.To) sspitzer#mozilla.org -> me
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha
Attached patch (Av1) <abDragDrop.js> (obsolete) — — Splinter Review 
Bug fix,
plus some cleanup.
Comment on attachment 143881 [details] [diff] [review]
(Av1) <abDragDrop.js>


'r=?':
Could you review and test it ?
Attachment #143881 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #143881 - Attachment is obsolete: true
Attachment #143881 - Flags: review?(neil.parkwaycc.co.uk)
Attached patch (Av1b) <abDragDrop.js> (obsolete) — — Splinter Review 
Av1, without most of the cleanup.
Attachment #144132 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 144132 [details] [diff] [review]
(Av1b) <abDragDrop.js>

>-      if (!targetDirectory.isMailList && 
>-          (!(targetDirectory.operations & targetDirectory.opWrite)))
>-        return false;      
>-      
>-      return true;
>+    return (targetDirectory.isMailList ||
>+            (targetDirectory.operations & targetDirectory.opWrite));
r=me if you reindent this.

>       var dragSession = dragService.getCurrentSession();
>+
>       if (!dragSession)
Nit: no point separating the initialization from the test.
Attachment #144132 - Flags: review?(neil.parkwaycc.co.uk) → review+
Av1b, with comment 4 suggestion(s).
Attachment #144132 - Attachment is obsolete: true
Comment on attachment 144973 [details] [diff] [review]
(Av1c) <abDragDrop.js>
[Checked in: Comment 9]


Keeping |(Av1b) <abDragDrop.js> 	 patch		2004-03-17 07:51 PST   
neil.parkwaycc.co.uk: review+|.
Attachment #144973 - Flags: superreview?(mscott)
Attachment #144973 - Flags: review+
Attachment #144973 - Flags: superreview?(mscott) → superreview+
Comment on attachment 144973 [details] [diff] [review]
(Av1c) <abDragDrop.js>
[Checked in: Comment 9]


'approval1.7=?':
Trivial code fix, no risk;
(Trying v1.7 instead of waiting for v1.8a, as v1.7 will become new
long-lived...)
Attachment #144973 - Flags: approval1.7?
Comment on attachment 144973 [details] [diff] [review]
(Av1c) <abDragDrop.js>
[Checked in: Comment 9]

a=mkaply
Attachment #144973 - Flags: approval1.7? → approval1.7+
Fix checked in.
Attachment #144973 - Attachment description: (Av1c) <abDragDrop.js> → (Av1c) <abDragDrop.js> [Checked in: Comment 9]
Attachment #144973 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.8alpha → mozilla1.7final
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.