confusing cancellation message for tokens

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
User Accounts
--
minor
RESOLVED FIXED
14 years ago
5 years ago

People

(Reporter: timeless, Assigned: sjoshi)

Tracking

2.17.7
Bugzilla 5.0
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
29 A request was cancelled from [% remoteaddress %].
 30 
 31 If you did not request this, it could be either an honest
 32 mistake or someone attempting to break into your [% terms.Bugzilla %] 
account.

what does 'request' mean in this context? does it reference the act 
of cancelling the request, or the original request. if it's the original 
request, and the user took the action of cancelling the request, what value does 
the statement add?

Updated

13 years ago
QA Contact: mattyt-bugzilla → default-qa

Comment 1

13 years ago
Looks valid.

Could it be as simple as replacing the first 'request' by something appropriate
to the type of token?

Updated

13 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows NT → All
Hardware: PC → All

Updated

12 years ago
Assignee: myk → attach-and-request

Comment 2

10 years ago
Unrelated to attachments & requests.
Assignee: attach-and-request → user-accounts
Component: Attachments & Requests → User Accounts
(Assignee)

Comment 3

5 years ago
Created attachment 778856 [details] [diff] [review]
Patch-v1

Replaced "request" text with subject of the email to correctly identify the cancelled request.
Assignee: user-accounts → joshi_sunil
Status: NEW → ASSIGNED
Attachment #778856 - Flags: review?(dkl)
Comment on attachment 778856 [details] [diff] [review]
Patch-v1

Review of attachment 778856 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/account/cancel-token.txt.tmpl
@@ +11,4 @@
>  Subject: [% PROCESS subject %]
>  X-Bugzilla-Type: admin
>  
> +A [% PROCESS subject %] from [% remoteaddress %].

We need to completely remove 'A '. We can do this on commit. r=dkl
Attachment #778856 - Flags: review?(dkl) → review+

Updated

5 years ago
Flags: approval?

Updated

5 years ago
Flags: approval? → approval+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified template/en/default/account/cancel-token.txt.tmpl
Committed revision 8675.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Target Milestone: --- → Bugzilla 5.0
You need to log in before you can comment on or make changes to this bug.