Closed Bug 237661 Opened 21 years ago Closed 21 years ago

SVG build with freetype doesn't compile with gcc 3.4

Categories

(Core :: SVG, defect, P2)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.8alpha1

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Whiteboard: [patch])

Attachments

(1 file)

An SVG build with freetype doesn't compile on gcc 3.4.  Trivial patch coming up,
although I'm a little puzzled by why the code is this way in the first place. 
(I also removed a stray semicolon a few days ago.)
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.8alpha
Comment on attachment 144053 [details] [diff] [review]
patch

r=afri
I still don't understand why this doesn't compile on gcc3.4, though.
Why do you find the original code puzzling?
The purpose of font_data is simply to avoid having to cast aData later in the
function. 
We only want an alias, not a new physical object on the stack. In the original
version (*&) the compiler shouldn't need to generate any code. Not that it
matters much, but I'm sure gcc is at fault here.
Attachment #144053 - Flags: review?(alex) → review+
No, this is clearly an error.  The result of a cast is an rvalue.
(In reply to comment #3)
> No, this is clearly an error.  The result of a cast is an rvalue.
Ah, I see. Thank you for clarifying this. My faith in the world is restored :-)
Fix checked in to trunk, 2004-03-18 17:36 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: