237692 - FireFox GTK2 fails to build on Solaris

Status: VERIFIED DUPLICATE of bug 209747

(Firefox Build System :: General, defect)

Description

[Roland Mainz]

FireFox GTK2 fails to build on Solaris like this:
-- snip --
/opt/SUNWspro/bin/CC -o firefox-bin -I/usr/openwin/include -features=tmplife
-xbuiltin=%all -mt  -DNDEBUG -DTRIMMED -xO2  nsBrowserApp.o
nsStaticComponents.o  -xildoff -zlazyload -zcombreloc    -L../../dist/bin
-L../../dist/lib -L../../dist/lib/components -lxpcom_compat_c -lxpconnect
-luconv -lucvmath -li18n -lctl -loji -lnecko -lnecko2 -lpref -lcaps -lrdf
-lhtmlpars -lgfxxprint -lgfx_gtk -limglib2 -lgkplugin -lwidget_gtk2
-lxremote_client -lgklayout -lmork -ldocshell -lprofile -lnsprefm
-lembedcomponents -lwebbrwsr -leditor -ltxmgr -lcomposer -lnsappshell -lchrome
-laccessibility -lpipboot -lpipnss -lpippki -lfileview -lmozfind
-lxremoteservice -lappcomps -ltoolkitcomps -lcookie -lxmlextras -lautoconfig
-lsystem-pref -ltransformiix -luniversalchardet -ltypeaheadfind -lwebsrvcs
-lnkfinger -lnkdatetime -lbrowsercomps -lunicharutil_s -lucvutil_s -lmozpango
-ljsj -lgtkxtbin -lgfxshared_s -lxlibrgb -lxprintutil -lgkgfx -lxulapp_s
../../dist/lib/libxulapp_s.a -L../../dist/bin -lmozjs -L../../dist/bin -lxpcom 
-L/shared/bigtmp/mozilla/nightlybuilds/north/firefox_gtk2/objdir_gtk1/dist/lib
-lplds4 -lplc4 -lnspr4 -lpthread -ldl -lrt  -lgtk-x11-2.0 -lgdk-x11-2.0
-latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangox-1.0 -lpango-1.0 -lgobject-2.0
-lgmodule-2.0 -ldl -lglib-2.0    -lsocket -ldl -lm  -L../../dist/lib/components
-L../../dist/lib -lmozpng -L../../dist/lib -lmozjpeg -L../../dist/lib -lmozz 
-L../../dist/bin -L../../dist/lib ../../dist/lib/libcrmf.a -lsmime3 -lssl3
-lnss3 -lsoftokn3   -lmoz_art_lgpl -lm  -L/usr/openwin/lib -R/usr/openwin/lib
-lXt -L/usr/openwin/lib -R/usr/openwin/lib -lXp -lXext -lX11 -L../../dist/lib
-lxpcom_compat    
Undefined                       first referenced
 symbol                             in file
inet_addr                          
../../dist/lib/components/libprofile.a(nsProfileLock.o)  (symbol belongs to
implicit dependency /usr/lib/libnsl.so.1)
inet_ntoa                          
../../dist/lib/components/libprofile.a(nsProfileLock.o)  (symbol belongs to
implicit dependency /usr/lib/libnsl.so.1)
ld: fatal: Symbol referencing errors. No output written to firefox-bin
gmake[3]: *** [firefox-bin] Error 1
gmake[3]: Leaving directory
`/shared/bigtmp/mozilla/nightlybuilds/north/firefox_gtk2/objdir_gtk1/browser/app'
gmake[2]: *** [libs] Error 2
gmake[2]: Leaving directory
`/shared/bigtmp/mozilla/nightlybuilds/north/firefox_gtk2/objdir_gtk1/browser'
gmake[1]: *** [tier_99] Error 2
gmake[1]: Leaving directory
`/shared/bigtmp/mozilla/nightlybuilds/north/firefox_gtk2/objdir_gtk1'
gmake: *** [default] Error 2
-- snip --

Comment 1

[Roland Mainz]

OK, dump question:
config/autoconf.mk lists this:
-- snip --
XLIBS           = -lX11 -lsocket  -lnsl
-- snip --
but this is not used in the link line for FireFox - why ?

Comment 2

[Brian Ryner (not reading)]

Attachment: patch for firefox and thunderbird

Comment 3

[Roland Mainz]

The patch still misses support for "Calendar" and "Composer" ...

Comment 4

[cls]

Comment on attachment 144068 [details] [diff] [review]
patch for firefox and thunderbird

Unless those apps are directly referencing X11 routines, that's not the right
fix.  Since this is a static build, the change should be made to
static-config.mk or just make MOZ_GTK2_LIBS contain XLIBS since it's apparently
broken on every platform besides linux (which only gets by due to shared
library dependencies).

Comment 5

[cls]

*** This bug has been marked as a duplicate of 209747 ***