Closed Bug 237726 Opened 20 years ago Closed 20 years ago

XUL elements aren't properly registered as DOM3 nodes

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.7final

People

(Reporter: neil, Unassigned)

Details

Attachments

(1 file)

Error: uncaught exception: [Exception... "Illegal operation on WrappedNative
prototype object"  nsresult: "0x8057000c (NS_ERROR_XPC_BAD_OP_ON_WN_PROTO)" 
location: "JS frame :: javascript: top.document.documentElement.textContent ::
<TOP_LEVEL> :: line 1"  data: no]

I did a scan of a fair number of elements and attributes and the only attributes
I had problems with were baseURI and textContent of xul elements so I assume the
issue is with the nsIDOM3Node registration.
Attached patch Proposed patchSplinter Review
Attachment #144084 - Flags: superreview?(jst)
Attachment #144084 - Flags: review?(jst)
You don't need nsIDOMElementCSSInlineStyle (.style property)?
Comment on attachment 144084 [details] [diff] [review]
Proposed patch

Good catch! r+sr=jst
Attachment #144084 - Flags: superreview?(jst)
Attachment #144084 - Flags: superreview+
Attachment #144084 - Flags: review?(jst)
Attachment #144084 - Flags: review+
(In reply to comment #2)
>You don't need nsIDOMElementCSSInlineStyle (.style property)?
No, it's define on nsIDOMXULElement.
Oh, ugh.  Yay XUL dom being different just because.  :(
Comment on attachment 144084 [details] [diff] [review]
Proposed patch

Low risk fix for erroneous exception accessing certain xul element attributes.
Attachment #144084 - Flags: approval1.7b?
Comment on attachment 144084 [details] [diff] [review]
Proposed patch

a=chofmann for 1.7.  wait until later today to make sure tag is cut and beta is
finished before checking in.
Attachment #144084 - Flags: approval1.7b? → approval1.7+
Target Milestone: --- → mozilla1.7final
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: