23775 - Pref to disable Java applet execution

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P3)

Description

[Norris Boyd]

Is the pref hooked up to disable Java? I'm creating a new bug for Java now that
I've completed the same thing for JavaScript (see bug 13023).

Comment 1

[drapeau]

Nope, the pref isn't hooked up yet.  We'll get to it after Beta 1.

Comment 2

[Norris Boyd]

Marking required beta2 features.

Comment 3

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 4

[leger]

On exception list for PR2, removing 5/16...giving [nsbeta2+]Exception Feature 
status.

Comment 5

[edburns]

Taking ownership

Comment 6

[edburns]

Attachment: fix for this bug.

Comment 7

[edburns]

I just added an attachment that fixes this bug.  However, we still need bug 
42314 to be fixed to really call 23775 fixed.

Here's the checkin comment for the patch.

M mozilla/js/src/liveconnect/jsj_class.c

  Removed an assert that was already dealt with at runtime via checking
  for null.  This assert was firing in the case when the user disabled
  Java via the prefs, and then went to an applet page.

M mozilla/modules/oji/src/nsJVMManager.cpp

  Hook up the logic for being aware of the state of the
  "security.java_enabled" preference.

M mozilla/modules/plugin/nglsrc/nsPluginHostImpl.cpp

  Don't load the applets if java is disabled.

Comment 8

[edburns]

Hello,

Can someone with a mac, maybe Raju, please build mozilla tip and test my 
fix to 23775?  Here's a test script, after building mozilla tip,
applying my patch, and getting java working.

1. Visit a page with an applet, see that the applet runs

2. In Mozilla do Edit->Preferences->Advanced and UN-check Java enabled

3. Press OK.

4. Shift-Reload the page with the applet.  The applet should not appear.

5. Stop mozilla

6. Restart mozilla

7. Visit a page with an applet.  The applet should not appear

8. In Mozilla do Edit->Preferences->Advanced and CHECK Java enabled

9. Shift-Reload the page with the applet.  The applet SHOULD appear.

Raju, can I assign this bug to you, and you can re-assign it back to me?

Thanks,

Ed

Comment 9

[edburns]

Waiting for Raju to test this on Mac before seeking checkin approval.

Raju, please assign this back to me when u r done.

Comment 10

[edburns]

Raju, I've checked out the M15-OJI branch and built it, with your NSPR and 
security.  It built fine.  I integrated this patch into my branch tree and 
tested it usinsg the below script.  It still works.  I'm waiting for you to 
tell me it works on the mac before seeking checkin approval.

Comment 11

[rpallath]

I had tried this on MacOS 9.0
Could try only local applets (cannot go out, because of proxy problems).

Tried the example  applets in MRJSDK2.2 (Bar/SunSphere/Guage).

Seems to be working as  indicated.

Reassigning back to Ed.

Comment 12

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 13

[drapeau]

Sorry for the late bug update.  Fixed should be merged in from the
M15-OJI-05292000 branch.

Comment 14

[shrirang khanzode]

Does this mean that this change is not in the trunk? Because even when I disable 
java on windows and mac (build :2000062608), I can load applets. Is this really 
fixed on the m17 trunk ? Thnx.

Comment 15

[leger]

Merge is not into trunk yet.  Working with leaf.

Comment 16

[edburns]

I'm putting the last bit of the merge in now.

Comment 17

[shrirang khanzode]

Verified with windows (2000070508) and mac (2000070311).

Comment 18

[shrirang khanzode]

verif