Closed Bug 237792 Opened 20 years ago Closed 16 years ago

bytes received does not update properly after pause/resume

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: ajschult784, Assigned: ajschult784)

References

Details

Attachments

(1 file)

patch
761 bytes, patch
benjamin
: review+
Details | Diff | Splinter Review 
If you run the net installer and pause it at some point, the byte count
displayed does not update properly.  If you pause at 500KB, it will wait until
you get to 1000KB and then display the byte count as actual-500KB.

Trivial patch to follow
Attached patch patch — — Splinter Review 
so the problem is that after pause, "PerformInstall" exists and resume then
calls it again, but the internal byte count gets reset.  The code in DownloadCB
is attempting to account for that, but it doesn't actually work.

this fixes it.
Attachment #144137 - Flags: review?(bsmedberg)
Comment on attachment 144137 [details] [diff] [review]
patch

ugh.  this is still the "right" patch, but I need to fix "pause" a bit more for
the patch to work.
Attachment #144137 - Flags: review?(bsmedberg)
Depends on: 238095
Comment on attachment 144137 [details] [diff] [review]
patch

with bug 238095 fixed, this actually works.
Attachment #144137 - Flags: review?(bsmedberg)
QA Contact: bugzilla → agracebush
Attachment #144137 - Flags: review?(bsmedberg) → review+
Attachment #144137 - Flags: superreview?(dveditz)
Product: Browser → Seamonkey
- Linux installer has been discontinued on trunk.
- Does this bug still apply to SeaMonkey 1.1.x ? Andrew?
QA Contact: agracebush → general
this can die
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Attachment #144137 - Flags: superreview?(dveditz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: