237803 - Unhiding the url bar doesn't update url address field to the currently displayed page

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Chris Petersen]

Build: 2004031508
Plaform: OS X 10.3.3
Expected Results: The url bar should display the currently displayed page url
after unhiding it
What I got: The url bar displays the url of a previous page when it was hidden

Steps to reproduce:

1) Notice the url address displayed in the bar
2) Select Hide Toolbar from the View menu
3) Select any bookmark from the Bookmark menu
4) After page loads, select Show Toolbar from the View menu
5) Notice the url address shows the previous page and not the current one

Comment 1

[Greg K.]

Yup, happens using 2004050308 (v0.8b) on OS X 10.2.8, as well.

Comment 2

[Tom de Grunt]

Attachment: Patch

The problem still remains when clicking the 'toggle toolbar' widget on the
window. Apparantly overloading the 'toggleToolbarShown' method is not enough.

Comment 3

[Stuart Morgan]

> Apparantly overloading the 'toggleToolbarShown' method is not enough.

Yes, that's just the menu-item action.

The question is, why doesn't updateLocationFields: do its job when the toolbar
is hidden? Is it not being called? Is mURLBar nil when the toolbar is hidden for
some reason? It would be good if we knew where this is breaking down so we can
try to fix it there.

(On a code formatting not, please make sure your editor inserts spaces instead
of tabs when making patches)

Comment 4

[Josh Aas]

As for not being able to override the on-window toolbar toggling widget, I've
filed bug 3703198 with Apple. Tom and I have tried, and from looking at the
cocoa mailing list it appears as though Pinkerton did too. Even if it is
possible, it is not documented or discoverable enough. I really think its not
possible though.

Comment 5

[Geoff "temporarily off bugmail" Beier]

Attachment: make sure the field editor is non-nill before comparing it to the firstResponder, which may be nil

The problem here is that in AutoCompleteTextField, setURI checks to see if the
URI field has focus and handles autocomplete if it does. The way this is done
is by comparing [self fieldEditor] to the firstResponder. If nothing has focus
(and therefore there is no firstResponder) and the text field is hidden (and
therefore there is no fieldEditor) AutoCompleteTextField believes the field has
focus and attempts to use the editor to update the field. Checking for a nil
fieldEditor fixes this and the field is updated properly whether it's hidden
using the window button or using the menu item.

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 158943 [details] [diff] [review]
make sure the field editor is non-nill before comparing it to the firstResponder, which may be nil

sr=pink

Comment 7

[Mike Pinkerton (not reading bugmail)]

landed.