bugzilla.mozilla.org will be intermittently unavailable on Saturday, March 24th, from 16:00 until 20:00 UTC.
I haven't found any user-noticable symptoms of this, but the sequence of events that happens when hitting pause/resume is: (pause) nsHTTPCon::Get calls DownloadCB DownloadCB flushes events before returning (gtk notices the click on "pause") DLPause fires off another event loop (resume) DLResume ends the event loop and starts PerformInstall() unfortunately, calling gtk_main_quit in DLResume has no imeadiate effect because it calls PerformInstall before retruning. So, pause/resume creates a paused orphan download. I have a patch for this, but I'm still testing fringe cases.
Created attachment 144432 [details] [diff] [review] patch the pause event loop now starts in ::Next, and calls PerformInstall from there if the user resumes. with this pause/resume/cancel/connection dropped works in normal/auto mode
and this doesn't break anything I've noticed, but it prevents me from fixing bug 237792
Summary: tweak pause/resume of net installer → rework pause/resume of net installer
Target Milestone: --- → mozilla1.8alpha
Comment on attachment 144432 [details] [diff] [review] patch r=dveditz
Attachment #144432 - Flags: review?(dveditz) → review+
Attachment #144432 - Flags: superreview?(bryner) → superreview+
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.