If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[nt 3.51] installer suggests invalid directory

RESOLVED FIXED in mozilla1.8alpha1

Status

SeaMonkey
Installer
P1
normal
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.8alpha1
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

On NT 3.51, Installer suggests "\mozilla.org\Mozilla" as installation directory...

(I did not try it out. I don't think I'd have had write access to any root
directory on this system)
http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/windows/setup/extra.c#7932
seems to be the function that gets the program files directory

Comment 2

14 years ago
could you possibly make available a reg export? (i don't really have time to 
play w/ the box)
HKLM\Software\Microsoft\Windows\CurrentVersion has no values directly in it, if
that's what you want to know.

Comment 4

14 years ago
As a side note, the installer does not check for access into several of the
install directories, it should default or prompt for each one of them...
have a patch to suggest parent of windows install directory if "program files"
reg key is unavailable

I won't address comment 4 in this patch.
Priority: -- → P1
Target Milestone: --- → mozilla1.8alpha
Created attachment 144989 [details] [diff] [review]
patch
Assignee: general → cbiesinger
Status: NEW → ASSIGNED
Created attachment 144992 [details] [diff] [review]
patch v2

let's try without leftover debugging code...
Attachment #144989 - Attachment is obsolete: true
Attachment #144992 - Flags: review?(dveditz+bmo)
Comment on attachment 144992 [details] [diff] [review]
patch v2

The firefox installer will need this change too (Ben forked the code).
r=dveditz
Attachment #144992 - Flags: review?(dveditz) → review+

Comment 9

14 years ago
dveditz: are you sure? firefox explicitly does not support nt3.51
Comment on attachment 144992 [details] [diff] [review]
patch v2

I don't really have the time and interest to patch/build/test randomly forked
code, someone else will have to fix firefox
Attachment #144992 - Flags: superreview?(roc)
Comment on attachment 144992 [details] [diff] [review]
patch v2

This should be separated out into a common function (and why isn't code being
shared between setup and uninstall?) but I'll let it slide.
Attachment #144992 - Flags: superreview?(roc) → superreview+
Checking in setup/extra.c;
/cvsroot/mozilla/xpinstall/wizard/windows/setup/extra.c,v  <--  extra.c
new revision: 1.135; previous revision: 1.134
done
Checking in uninstall/extra.c;
/cvsroot/mozilla/xpinstall/wizard/windows/uninstall/extra.c,v  <--  extra.c
new revision: 1.30; previous revision: 1.29
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.