238186 - URL field in Page Info dialog appears blue

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Tom Pike]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040320 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040320 Firefox/0.8.0+

URL field in the Page Info dialog is incorrectly shown as blue (it is not a
clickable link).  Additionally, the text in the context menu is underlined.

Reproducible: Always
Steps to Reproduce:
1. Visit any web page
2. Tools menu -> Page Info (Ctrl + J)
3. Context-click on URL

Actual Results:  
URL is blue and text in the context menu is underlined blue.

Expected Results:  
URL should be black and text in the context menu should not be underlined.

Suspect it may have been caused by the CSS changes made to fix bug 207403.

Comment 1

[Bill Mason]

Confirming new.

Comment 2

[Steffen Wilberg]

This is indeed a regression from pch's checkin for bug 207403:
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=03%2F20%2F2004+00%3A01&maxdate=03%2F20%2F2004+00%3A01

Comment 3

[Steffen Wilberg]

Attachment: simple patch: remove class="text-link" from pageInfo.xul

In Page Info, the URL isn't a link, so it shouldn't look like a link.

Comment 4

[Steffen Wilberg]

Comment on attachment 144472 [details] [diff] [review]
simple patch: remove class="text-link" from pageInfo.xul

pch, this is your regression. My patch for bug 207403 didn't affect Page
Info...

Comment 5

[Pierre Chanial]

is this class text-link in pageinfo.xul specific to firefox? (not in seamonkey?)

Comment 6

[Jeff Walden [:Waldo]]

(In reply to comment #5)
> is this class text-link in pageinfo.xul specific to firefox? (not in seamonkey?)

The one the patch changed?  At a glance I would think so.  First, the modified
file is in mozilla/toolkit.  Second, Page Info is styled by
mozilla/themes/*/navigator/pageInfo.css.  Third, the only XML stylesheet rule in
the Page Info XUL file for Mozilla is at
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/pageInfo.xul#29,
and it references a chrome://navigator file (presumably the pageInfo.css
mentioned above).

Comment 7

[Jeff Walden [:Waldo]]

Oops, I think I might have misunderstood the question.  Seamonkey does use a
.text-link class, but it's obviously (see above comment) a different one from
the one Firefox uses.  See the results in mozilla/themes for this LXR search:

http://lxr.mozilla.org/mozilla/search?string=text-link

Comment 8

[Steffen Wilberg]

(In reply to comment #5)
> is this class text-link in pageinfo.xul specific to firefox? (not in seamonkey?)
Seamonkey's pageInfo.xul has got the class "text-link" as well, but no style
rule for it. Compare:

Seamonkey's Console:
mozilla/xpfe/components/console/resources/content/console.xul
  references the stylesheet: "chrome://communicator/skin/"
  which means "chrome://communicator/skin/communicator.css"
    which contains @import url("chrome://communicator/skin/formatting.css")
      which _does_ contain the class "text-link".

Seamonkey's Page Info:
mozilla/xpfe/browser/resources/content/pageInfo.xul
  references the stylesheet: "chrome://navigator/skin/pageInfo.css"
    which contains @import "chrome://global/skin/"
    which means "chrome://global/skin/global.css"
      which contains @import url("chrome://global/skin/formatting.css");
        which _does not_ contain the class "text-link" in Seamonkey.

These formatting.css files are different. The former formatting.css isn't used
in Firefox.
The latter formatting.css, which is used in Firefox's JS Console as well, didn't
contain the the class "text-link" until the checkin mentioned in comment 2. But
now it does.

I think the right thing to do is to remove the class "text-link" from
pageInfo.xul, because it wasn't used before. The URL isn't a link there, so it
shouldn't start to look like a link.

Comment 9

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Is this bug theme-specific? I'm using the Apollo theme and the URL does not
appear to be blue. Nor is it a clickable, active link.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040321 Firefox/0.8.0+
(daihard: XFT+GTK2; opt. for P4/SSE-2)

Comment 10

[Florian Sievert]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040319 Firefox/0.8.0+
Seems like I am not able to reproduce it under Linux with the default theme.
Maybe this problem is not theme-specific, but os-specific? Are there any linux
users that can confirm this bug?

Comment 11

[Steffen Wilberg]

Yes, this bug does affect Linux. I see it with Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.7b) Gecko/20040327 Firefox/0.8.0+ (Steffen), which is a GTK2/XFT
build, after backing out my patch. Using the default theme.
Florian, the regression was introduced on 03/20, see comment 2. Get a newer
build :-)
Bradley, this may indeed be theme-specific, because a css file was modified, see
comment 2. Themers need to tweak these files. Try the default theme.

Comment 12

[Christopher Vendemio]

The context menu needs to be fixed but I kind of like the link text being blue.

Comment 13

[Hussam Al-Tayeb]

(In reply to comment #11)
> Bradley, this may indeed be theme-specific, because a css file was modified, see
> comment 2. Themers need to tweak these files. Try the default theme.

It also happens with the default theme. I see this on the windows with the
default theme using this build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040424
Firefox/0.8.0+

Comment 14

[Steffen Wilberg]

>> Try the default theme.
> It also happens with the default theme.
I meant: Try the default theme to see this bug. :-)

Comment 15

[Mike Connor [:mconnor]]

checked in branch and trunk 2004-05-02 08:59

Comment 16

[Steffen Wilberg]

Bug 195492 has reintroduced class="text-link". Reopening.

Comment 17

[Daniel Brooks [:db48x]]

checked in a fix for these two regressions. thanks guys.