warnings about conversion from 'int32' to 'char' and 'jschar'

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

14 years ago
r:/mozilla\js\src\jsdtoa.c(2683) : warning C4244: '=' : conversion from 'int32' 
to 'char', possible loss of data
r:/mozilla\js\src\jsregexp.c(275) : warning C4244: 'initializing' : conversion 
from 'int32' to 'jschar', possible loss of data
r:/mozilla\js\src\jsregexp.c(284) : warning C4244: 'initializing' : conversion 
from 'int32' to 'jschar', possible loss of data
r:/mozilla\js\src\jsstr.c(743) : warning C4244: '=' : conversion from 'int32' 
to 'jschar', possible loss of data
r:/mozilla\js\src\jsstr.c(790) : warning C4244: '=' : conversion from 'int32' 
to 'jschar', possible loss of data
(Assignee)

Comment 1

14 years ago
Created attachment 144514 [details] [diff] [review]
cast dig (as done a few lines above) and cast back to jschar for JS_TOUPPER/JS_TOLOWER
(Assignee)

Comment 2

14 years ago
Comment on attachment 144514 [details] [diff] [review]
cast dig (as done a few lines above) and cast back to jschar for JS_TOUPPER/JS_TOLOWER

i don't think i really need reviews for these changes, but the tree is frozen,
so a review won't hurt.
Attachment #144514 - Flags: review?(brendan)
Created attachment 145395 [details] [diff] [review]
I checked this in

80th column preservation in jsstr.h.

/be
Attachment #144514 - Attachment is obsolete: true
.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Attachment #144514 - Flags: review?(brendan)
You need to log in before you can comment on or make changes to this bug.