Closed
Bug 238578
Opened 20 years ago
Closed 20 years ago
Mismatched PR_MALLOC and free in os2poll.c
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.5
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
603 bytes,
patch
|
mkaply
:
review+
mkaply
:
approval1.7+
|
Details | Diff | Splinter Review |
In os2poll.c, function _PR_MD_PR_POLL, the int array 'socks' is allocated with NSPR's PR_MALLOC(), but is freed with Standard C library's free(). This is a mismatch of allocation and deallocation functions.
|
Assignee | |
Comment 1•20 years ago
|
||
Use PR_Free instead of free.
|
|
Assignee | |
Updated•20 years ago
|
Attachment #144706 -
Flags: review?(pkw)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 144706 [details] [diff] [review] Proposed patch r=mkaply Nice catch a=mkaply for checkin if it mattersfor NSPR
Attachment #144706 -
Flags: review?(pkw)
Attachment #144706 -
Flags: review+
Attachment #144706 -
Flags: approval1.7+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Patch checked in on the NSPR trunk (NSPR 4.5) and NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.7 final).
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.5
You need to log in
before you can comment on or make changes to this bug.
Description
•