"change anything on the selected" is awkward in "bugs_not_changed" error

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
User Interface
--
minor
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: timeless, Assigned: Shane H. W. Travis)

Tracking

unspecified
Bugzilla 2.20
Bug Flags:
approval +

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

15 years ago
123   [% ELSIF error == "bugs_not_changed" %]
124     [% title = BLOCK %][% terms.Bugs %] Not Changed[% END %]
125     Um, you apparently did not change anything on the selected [% terms.bugs %].

change "on" to "in"

Comment 1

15 years ago
Created attachment 144900 [details] [diff] [review]
Patch on => in.

Updated

15 years ago
Attachment #144900 - Attachment is obsolete: true
Attachment #144900 - Flags: review-

Comment 2

15 years ago
Created attachment 144902 [details] [diff] [review]
Oops. Submitting irrelevant patch hunks is bad.

Updated

15 years ago
Attachment #144902 - Flags: review?

Updated

15 years ago
Flags: approval?

Comment 3

15 years ago
Comment on attachment 144902 [details] [diff] [review]
Oops. Submitting irrelevant patch hunks is bad.

Doh.
Attachment #144902 - Flags: review? → review+
Hmmm, this sounds just as awkward as the original one to me...  opinions anyone?
"Um, you didn't change any fields, so there's nothing for me to do."?

Gerv
Comment on attachment 144902 [details] [diff] [review]
Oops. Submitting irrelevant patch hunks is bad.

I don't think either sounds any better than the other.	Gerv's sounds a little
better to me.  If we have to change this as all, lets go with something along
the lines of what he suggested.
Attachment #144902 - Flags: review-
Flags: approval?
(Assignee)

Comment 7

14 years ago
Of more interest, perhaps, is the fact that I cannot raise this error. I assume 
from looking at process_bug.cgi (the only place where it is called), and from 
context, that it's supposed to pop up if you hit 'commit' without changing 
anything on a bug... but that's not what happens. I get a 'Changes Submitted' 
screen that sends mail to nobody, and which adds nothing to the Bug Activity 
screen.

Right now, this may as well be removed as modified, as I cannot generate this 
error message on 2.16.7, 2.18, or the tip.

Comment 8

14 years ago
travis, you need to change several bugs at once. Select some of them and do
nothing else except hitting the 'Commit' button. The message error then appear. :)
OS: Windows XP → All
Hardware: PC → All
(Assignee)

Comment 9

14 years ago
(In reply to comment #8)
> travis, you need to change several bugs at once. Select some of them and do
> nothing else except hitting the 'Commit' button.

Doing that raises the no_bugs_chosen error message; this bug is about the 
bugs_not_changed error message. 
(Assignee)

Comment 10

14 years ago
whoops... I missed the 'select some of them' part. I just clicked 'commit' 
after selecting none of them, thus raising the wrong error.

Patch to follow.
(Assignee)

Comment 11

14 years ago
Created attachment 174099 [details] [diff] [review]
Code patch for tip
Assignee: myk → travis
Attachment #144902 - Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Attachment #174099 - Flags: review?
(Assignee)

Comment 12

14 years ago
Created attachment 174100 [details] [diff] [review]
Code patch for tip, take 2

All that, and I don't even change 'on' to 'in'. :)
Attachment #174099 - Attachment is obsolete: true
Attachment #174100 - Flags: review?

Updated

14 years ago
Attachment #174099 - Flags: review?

Updated

14 years ago
Attachment #174100 - Flags: review? → review+

Updated

14 years ago
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
Flags: approval? → approval+
(Assignee)

Comment 13

14 years ago
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-
error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.93; previous revision: 1.92
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.