238802 - Input filter for integer sort key gives bad error output

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

Pick sort key "327.7", select save changes.

actual results:
      <font size="+2">
    The sort key must be an integer between 0 and 32767 inclusive.
    It cannot be <em></em>.
  
      </font>

expected results: um ...

Comment 1

[Frédéric Buclin]

Attachment: trivial patch, v1

We cannot use $::FORM{} if detaint_natural "fails".

Comment 2

[Max Kanat-Alexander]

Comment on attachment 175863 [details] [diff] [review]
trivial patch, v1

Yes, obviously correct on inspection.

Comment 3

[Dave Miller [:justdave]]

/me notes that we have to do an assignment like this anyway if you switch to
$cgi->param since you can't detaint the results of a function if it's not in a
variable already.

Comment 4

[Shane H. W. Travis]

Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.15; previous revision: 1.14
done