238874 - remove %FORM and %COOKIE from colchange.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Dave Miller [:justdave]]

This should be an easy one.

80:if (defined $::FORM{'rememberedquery'}) {
82:    if (defined $::FORM{'resetit'}) {
86:            if (defined $::FORM{"column_$i"}) {
90:        if (exists $::FORM{'splitheader'}) {
91:            $splitheader = $::FORM{'splitheader'};
101:                      -value => $::FORM{'splitheader'},
105:    $vars->{'redirect_url'} = "buglist.cgi?$::FORM{'rememberedquery'}";

122:if (defined $::COOKIE{'COLUMNLIST'}) {
123:    @collist = split(/ /, $::COOKIE{'COLUMNLIST'});
129:$vars->{'splitheader'} = $::COOKIE{'SPLITHEADER'} ? 1 : 0;

Comment 1

[Christian Reis]

Attachment: kiko_v1: fix

Comment 2

[Christian Reis]

Attachment: kiko_v2: include cookie changes

Comment 3

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.40; previous revision: 1.39

FIXED, thanks.

Comment 4

[Christian Reis]

Maybe I'm blind, but..

Comment 5

[Christian Reis]

Attachment: kiko_2_v1: doh

No idea how I missed this.

Comment 6

[Christian Reis]

Dave, I seem to have missed this. Does saying `I'm sorry' fix things? 

Comment 7

[Dave Miller [:justdave]]

checked in for kiko, since he's off wandering Europe somewhere.