Closed Bug 238874 Opened 16 years ago Closed 16 years ago

remove %FORM and %COOKIE from colchange.cgi

Categories

(Bugzilla :: Bugzilla-General, defect)

2.17.7
defect
Not set

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: justdave, Assigned: kiko)

References

Details

Attachments

(2 files, 1 obsolete file)

This should be an easy one.

80:if (defined $::FORM{'rememberedquery'}) {
82:    if (defined $::FORM{'resetit'}) {
86:            if (defined $::FORM{"column_$i"}) {
90:        if (exists $::FORM{'splitheader'}) {
91:            $splitheader = $::FORM{'splitheader'};
101:                      -value => $::FORM{'splitheader'},
105:    $vars->{'redirect_url'} = "buglist.cgi?$::FORM{'rememberedquery'}";

122:if (defined $::COOKIE{'COLUMNLIST'}) {
123:    @collist = split(/ /, $::COOKIE{'COLUMNLIST'});
129:$vars->{'splitheader'} = $::COOKIE{'SPLITHEADER'} ? 1 : 0;
Blocks: 236678
No longer blocks: 225818
Attached patch kiko_v1: fix (obsolete) — Splinter Review
Assignee: nobody → kiko
Status: NEW → ASSIGNED
Attachment #144987 - Attachment is obsolete: true
Target Milestone: --- → Bugzilla 2.18
Attachment #144988 - Flags: review?(justdave)
Attachment #144988 - Flags: review+
Flags: approval?
Attachment #144988 - Flags: review?(justdave)
Flags: approval? → approval+
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.40; previous revision: 1.39

FIXED, thanks.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Maybe I'm blind, but..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch kiko_2_v1: dohSplinter Review
No idea how I missed this.
Attachment #146024 - Flags: review?(vlad)
Attachment #146024 - Flags: review?(vlad) → review+
Dave, I seem to have missed this. Does saying `I'm sorry' fix things? 
Flags: approval+ → approval?
Flags: approval? → approval+
checked in for kiko, since he's off wandering Europe somewhere.
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.