23904 - PlainText:   replacing spaces in replies

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Chris McAfee]

Linux.
I just replied to a message in plaintext mail that
replaced spaces with " ":

Chris McAfee wrote:


>
Please put "r=" for reviewers in your checkin comments.
>
We've had an early spurt of review-less checkins,
>
we have these to avoid crappy verification days like the
>
one we had today.  If you want the tree to open at 11am,
>
we need to be careful about what goes into the tree, duh.
>
Bcc-ing internal people.

Repeating above statement, plus: brain-dead easy things
are Ok, use your head.  If you have a bug fix or lots of
lines changing, that's probably a review candidate.

Keep the tree green, let's not sink things for Friday.
Sending this with 5.0, :-)

-Chris


--

I had trouble reproducing this.

Comment 1

[Akkana Peck]

I saw this, too, a few days ago, but haven't seen a reproducible case.  Adding
Naoki in case it might have something to do with the entity converter (which I
think recently changed its nbsp behavior).

Comment 2

[nhottanscp]

I changed the message send behavior to always send   instead of raw
Latin1 0xA0. But I think this bug itself is not related to the entity converter
which generates entity. What's missing here is to convert the entities back to
character codes.

Comment 3

[Akkana Peck]

The question is how the nbsp character got in there in the first place -- it
should never be there for plaintext mail, we should be using normal spaces.

I just checked the plaintext editor, and both normal typing and Paste As
Quotation use normal spaces according to OutputText, OutputHTML, and Save.  So I
don't think the editor is what is putting in these nbsp's.

Comment 4

[nhottanscp]

Right, it doesn't seem to be the editor.
I set a break point after GetContentsAs() in nsMsgCompose::SendMsg, there are no
 .
Also after nsMsgI18NSaveAsCharset() no   either.
But after that, nsMsgCompose::_SendMsg is called. That function is for html send
and calls nsMsgI18NSaveAsCharset() with a content type text/html. So it
generates   because the input option was text/html.
So the question is,
If SendMsg is for text/plain and _SendMsg is for text/html then why both are
called for this reply quote case?

Comment 5

[nhottanscp]

Well, I was confused, text/html case is in a different file.
The part was recently added by rhp and I actually reviewed it. I think we have
now the situation which calls nsMsgI18NSaveAsCharset twice (with wrong content
type) in some situation.
Reassign to rhp.

Comment 6

[rhp (gone)]

I check to make sure that I only do nsMsgI18NSaveAsCharset() once per message
send.

- rhp

Comment 7

[fenella]

Linux  and Mac (2000-04-18-08 M16) 
Win32 (2000-04-18-09 M16) 
I do not see this problem in these builds in replied plain text.

Comment 8

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/fb9fd1388baf
[fenix] Upgrade AndroidX Espresso Deps and support API 30 (https://github.com/mozilla-mobile/fenix/pull/23904)