cvsmailfilter mails should say who made the check-in

VERIFIED FIXED

Status

VERIFIED FIXED
15 years ago
4 years ago

People

(Reporter: justdave, Assigned: justdave)

Tracking

Details

Attachments

(1 attachment)

At least for the Bugzilla checkins, I *really* want to see who made the checkin
when I get the checkin mails.  The current mails don't offer this information.
Created attachment 145012 [details] [diff] [review]
Patch v1

This adds a command-line option to cvsmailfilter.pl to instruct it to include
the username of the committer in the notification mail.

I added it as an option because the loginfo entries look like some of the
mailings may be going to automated processes, so I don't want to screw with the
formatting for anyone that doesn't need it. :)
Myk: can you review this?  (no flags to set on the attachment in this product :)
Leaf: can you take a peek at this and review it?  There's no review flags on
this product, so I can't formally request it :)

Comment 4

15 years ago
Comment on attachment 145012 [details] [diff] [review]
Patch v1

r=leaf; it's always bothered me that i didn't know who was changing the modules
file :)
Also added the -c flag to the entries for cvs-checkins@bugzilla.org and
sysalerts@mozilla.org

Checking in cvsmailfilter.pl;
/cvsroot/CVSROOT/cvsmailfilter.pl,v  <--  cvsmailfilter.pl
new revision: 1.9; previous revision: 1.8
done
Checking in loginfo;
/cvsroot/CVSROOT/loginfo,v  <--  loginfo
new revision: 1.40; previous revision: 1.39
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
got mail today saying CVSROOT modules was modified by leaf.  That was the last
thing I was waiting for to know this was working right.  It works :)

If anyone wants the ID of the person who committed included in checkin mails to
other mailing lists, let me, myk, or leaf know.
Status: RESOLVED → VERIFIED
Product: mozilla.org → mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.