239056 - cvsmailfilter mails should say who made the check-in

Status: VERIFIED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Dave Miller [:justdave]]

At least for the Bugzilla checkins, I *really* want to see who made the checkin
when I get the checkin mails.  The current mails don't offer this information.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

This adds a command-line option to cvsmailfilter.pl to instruct it to include
the username of the committer in the notification mail.

I added it as an option because the loginfo entries look like some of the
mailings may be going to automated processes, so I don't want to screw with the
formatting for anyone that doesn't need it. :)

Comment 2

[Dave Miller [:justdave]]

Myk: can you review this?  (no flags to set on the attachment in this product :)

Comment 3

[Dave Miller [:justdave]]

Leaf: can you take a peek at this and review it?  There's no review flags on
this product, so I can't formally request it :)

Comment 4

[Daniel (Leaf) Nunes]

Comment on attachment 145012 [details] [diff] [review]
Patch v1

r=leaf; it's always bothered me that i didn't know who was changing the modules
file :)

Comment 5

[Dave Miller [:justdave]]

Also added the -c flag to the entries for [e-mail] and
[e-mail]

Checking in cvsmailfilter.pl;
/cvsroot/CVSROOT/cvsmailfilter.pl,v  <--  cvsmailfilter.pl
new revision: 1.9; previous revision: 1.8
done
Checking in loginfo;
/cvsroot/CVSROOT/loginfo,v  <--  loginfo
new revision: 1.40; previous revision: 1.39
done

Comment 6

[Dave Miller [:justdave]]

got mail today saying CVSROOT modules was modified by leaf.  That was the last
thing I was waiting for to know this was working right.  It works :)

If anyone wants the ID of the person who committed included in checkin mails to
other mailing lists, let me, myk, or leaf know.