23912 - unable to immediately remove values or fields in Wallet Contents

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[sairuh (rarely reading bugmail)]

occurs in linux and winNT comm bits (2000-011308); not yet tested on mac. to
repro:

1. make sure you've already captured form data. as an example, go to
http://people.netscape.com/morse/wallet/samples/INTERVIEW.HTML, fill out some of
the fields there, and go to Tasks > My Wallet > Capture Form. enter db key if
prompted.

2. go to Tasks > My Wallet > Wallet Contents... this brings up the dialog
labelled Manage Personal Data.

3. select any of the values (under "Entries for field") OR any of the fields.

4. click the [corresponding] Remove button, click OK to close dialog.

result: if you go to a form to fill out (eg,
http://people.netscape.com/morse/wallet/samples/amazon.html and got to Tasks >
My Wallet > Safe Form Fill), the value or field will still be filled in. the
same goes for reopening the Wallet Contents dialog. i needed to quit and restart
seamonkey in order to see the change.

expected: Steve says that changes should be immediate and not require a restart.

Comment 1

[Stephen P. Morse]

OK, I see what the problem is -- a one-line change in wallet.cpp.  I have some
other massive changes to be checked in for that file so as soon as I get the
green light to check in my other changes, I'll sneak this one in as well.

Comment 2

[Stephen P. Morse]

Fix checked in.  Change was one line in wallet.cpp as mentioned above.

Comment 3

[sairuh (rarely reading bugmail)]

this works fine on winNT [2000020214, non-comm] and linux [2000020209, comm].
i'll verify this one and open another for the mac (which just hangs when doing
formfill).

Comment 4

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/df273e60cf0a
[fenix] closes https://github.com/mozilla-mobile/fenix/issues/23912: remove sentry reporting from WallpaperDownloader