Choosing Unblock Images from this Server in context menu whitelists site instead of removing permission

RESOLVED FIXED in mozilla1.7final

Status

()

Core
Image Blocking
P2
normal
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: mconnor, Assigned: mconnor)

Tracking

Trunk
mozilla1.7final
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
I fixed this a while back in Tools->Cookie Manager and Tools->Image Manager, but
not in the context menu.  Yay morse!
(Assignee)

Comment 1

14 years ago
in 1.8a I might implement something in the overlay to give the option of
whitelisting sites for images if images are turned off by default.  It doesn't
make sense to give options to block images from sites if you're already blocking
images from everyone.
Blocks: 216743
Status: NEW → ASSIGNED
(Assignee)

Comment 2

14 years ago
Created attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

missed a couple references to the imageblocker.enabled pref that was removed a
while back, which is the extra lines here.
(Assignee)

Updated

14 years ago
Attachment #145146 - Flags: review?(dwitte)

Comment 3

14 years ago
Comment on attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

indeed. r=me
Attachment #145146 - Flags: review?(dwitte) → review+

Comment 4

14 years ago
simple and low-risk enough for 1.7, if time permits.
Target Milestone: --- → mozilla1.7final

Updated

14 years ago
Attachment #145146 - Flags: superreview+
(Assignee)

Updated

14 years ago
Attachment #145146 - Flags: approval1.7?
(Assignee)

Updated

14 years ago
Priority: -- → P2
(Assignee)

Updated

14 years ago
Component: Cookies → Image Blocking
(Assignee)

Updated

14 years ago
No longer blocks: 216743

Updated

14 years ago
QA Contact: cookieqa → nobody

Comment 5

14 years ago
Comment on attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #145146 - Flags: approval1.7? → approval1.7+
(Assignee)

Comment 6

14 years ago
checked in 2004-04-07 16:23
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.