Closed Bug 239240 Opened 16 years ago Closed 16 years ago

Choosing Unblock Images from this Server in context menu whitelists site instead of removing permission

Categories

(Core :: Image Blocking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.7final

People

(Reporter: mconnor, Assigned: mconnor)

Details

Attachments

(1 file)

I fixed this a while back in Tools->Cookie Manager and Tools->Image Manager, but
not in the context menu.  Yay morse!
in 1.8a I might implement something in the overlay to give the option of
whitelisting sites for images if images are turned off by default.  It doesn't
make sense to give options to block images from sites if you're already blocking
images from everyone.
Blocks: 216743
Status: NEW → ASSIGNED
missed a couple references to the imageblocker.enabled pref that was removed a
while back, which is the extra lines here.
Attachment #145146 - Flags: review?(dwitte)
Comment on attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

indeed. r=me
Attachment #145146 - Flags: review?(dwitte) → review+
simple and low-risk enough for 1.7, if time permits.
Target Milestone: --- → mozilla1.7final
Attachment #145146 - Flags: superreview+
Attachment #145146 - Flags: approval1.7?
Priority: -- → P2
Component: Cookies → Image Blocking
No longer blocks: 216743
QA Contact: cookieqa → nobody
Comment on attachment 145146 [details] [diff] [review]
use .remove() instead of .add() (also remove obsolete comments)

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #145146 - Flags: approval1.7? → approval1.7+
checked in 2004-04-07 16:23
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.