239456 - Junk controls don't run if account puts copy of sent message in Inbox

Status: RESOLVED DUPLICATE of bug 239168

(MailNews Core :: Filters, defect)

Description

[Mike Cowperthwaite]

If an account is configured to put a copy of the Sent message into the Inbox of 
the account (rather than into the Sent folder), then incoming messages are not 
subjected to automatic Junk Controls.  It is still possible to run Junk Controls 
manually, in which case they operate as expected.

I'm seeing this on a POP account, 1.7b-0402 (Pinball theme), Windows 2000.  
I don't know if it occurs on IMAP, and I don't know (yet) if selecting a folder 
other than Inbox causes the same problem.

I only caught this problem because it was mentioned offhandedly in a newsgroup 
post. That reporter apparently encountered it using Thunderbird 0.5, also under 
Windows.

To reproduce:
1) Configure account with reasonably well-trained junk controls to place the 
Sent messages into the Inbox instead of the Sent folder.
2) Await spam.

Actual results:
When junk arrives, it is not marked as junk and is not moved.  However, 
selecting   Tools|Run Junk Mail Controls on Folder   causes the message to be 
marked as junk, and moved if that option is selected.

Expected results:
All incoming mail is checked for junkitude.

Comment 1

[Mike Cowperthwaite]

I've run further tests and determined that the problem does not happen if some 
other folder is selected for Sent, just if the Inbox is.

Comment 2

[guanxi]

Bug 227915 is the same bug in Thunderbird.

I don't know if Moz and TBird are similar enough to dupe this.

Comment 3

[David :Bienvenu]

*** Bug 227915 has been marked as a duplicate of this bug. ***

Comment 4

[David :Bienvenu]

oh, yes, this is because we don't run the junk controls on the Sent folder, even
if the folder has the inbox flag set - we should always run the junk controls on
the inbox, even if the sent flag is set.

Comment 5

[neomjp]

Attachment: make nsMsgDBFolder::CallFilterPlugins check for MSG_FOLDER_FLAG_INBOX

I still see this in  Thunderbird 0.8 for Mac OS X.

(In reply to comment #4)
> oh, yes, this is because we don't run the junk controls on the Sent folder,
even

This behavior is specified in 
http://lxr.mozilla.org/aviarybranch/source/mailnews/base/util/nsMsgDBFolder.cpp#1817


CVS Blame wrongly says that this part is from bienvenu 1.196, but actually it
is from sspitzer 1.188 & 1.189 to fix bugs 197149 & 204807

> if the folder has the inbox flag set - we should always run the junk controls
on
> the inbox, even if the sent flag is set.

This patch makes junk controls run on inbox even if other flags are set.

Comment 6

[neomjp]

I am glad to see that bienvenu checked an essentially the same patch as mine in
as a fix for Bug 239168. Should this bug be resolved fixed?

Comment 7

[David :Bienvenu]

marking as dup.

*** This bug has been marked as a duplicate of 239168 ***