239476 - Page and table background colors do not change

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect, P3)

Description

[Payam Minoofar]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040316
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040316

I can the page background color once.  But, once it's changed, I cannot change
it again.  I have to restart mozilla to get the second change to take.  I
generally get to 1 background color change per session, it seems.

I'm running 1.7B on the latest Panther.

Reproducible: Always
Steps to Reproduce:
1.  Open composer
2.  Change the page background color by going to "Format" in the menu bar and
choosing "Page colors and Background" and choosing a different color.  (Or
choose "table or cell properties" by right clicking on a table.)
3.  Repeat step 2.

Actual Results:  
On step 2, the bg color does change.  Repeating step 2 fails to change the page
bg color.

Expected Results:  
Page bg color should change

Comment 1

[Frank Wein [:mcsmurf]]

Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
Gecko/20040513
I get no errors in the JS Console when trying to change the color.
Changing the background color via the Format Toolbar works.

Comment 2

[Payam Minoofar]

(In reply to comment #1)
> Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
> Gecko/20040513
> I get no errors in the JS Console when trying to change the color.
> Changing the background color via the Format Toolbar works.

Ok. Now we are at build 2004042110 (RC1), and the bug is mostly gone. I went
through and changed table and cell colors many times both through the context
menu through "table or cell background color" under the "table" menu item. It
worked almost every time. A couple of times, however, when I changed the table
background color from the main menu, two cells remained unchanged. I was able to
change their colors through the context menu, but doing so through the main menu
failed repeatedly.

Comment 3

[Frank Wein [:mcsmurf]]

I only tried changing background color so, not table background.

Comment 4

[R.K.Aa.]

*** Bug 250308 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 252837 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Set and remove attributes consistently

This fixes the bug (for body, table cells, tables).

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 154172 [details] [diff] [review]
Set and remove attributes consistently

r=[e-mail]

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 9

[[e-mail]]

Is that the lot now? (I doubt it...)

Comment 10

[Boris Zbarsky [:bzbarsky]]

I don't know.  I scanned the other JS files in that dir, and didn't see anything
obviously wrong after this patch, but I didn't scan all that carefully

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 260708 has been marked as a duplicate of this bug. ***