239635 - add support for ignoring assertions on windows (windbgdlg)

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[timeless]

I'd like to be able to ignore certain assertions, i have a short list, the most
important one comes from CNavDTD and happens for each and every spec of
whitespace in a web page. It's amazingly annoying.

I've made this somewhat flexible, instead of absolutely matching an assertion
message, it matches on a single fragment of an assertion. one fragment is always
the filename with a comma affixed.

[HKEY_CURRENT_USER\Software\mozilla.org\windbgdlg]
"r:/mozilla/htmlparser/src/CNavDTD.cpp,"=DWORD:5

Comment 1

[timeless]

Attachment: patch

Comment 2

[Ere Maijala (slow)]

Why do we have such assertions in the first place? I don't think assertions are
the right thing to do when there's something unexpected in an input file. 

Comment 3

[timeless]

the assertions i'm ignoring are ones w/ bugs filed and well understood problems.

the navdtd one is because whitespace and related ilk follow normal tags in a
certain enum type, but the tostring method only applies to normal tags.

the assertion itself isn't about the file (whitespace is perfectly valid in
html, and is pretty much required for any nontrivial document), it's about an
incorrect use of an api.

Comment 4

[Doug Turner (:dougt)]

timeless, any thoughts on using a flat file instead of the registry?

Comment 5

[timeless]

windbgdlg is a temporary instance creature, each assert triggers a new one.
reading in a file would be really bad. the registry should have much better
performance characteristics. windbgdlg really needs to be as fast as possible.

Comment 6

[timeless]

Comment on attachment 145440 [details] [diff] [review]
patch

mozilla/xpcom/windbgdlg/windbgdlg.cpp	1.3

Comment 7

[timeless]

mozilla-org/html/build/win32-debugging-faq.html 	1.14