239649 - menu arrows dissapear in certain themes

Status: VERIFIED INVALID

(Firefox :: Menus, defect)

Description

[Kevin Davis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040403 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040403 Firefox/0.8

When calling the list-style-image in the selector .bookmark-item using
-moz-image-region, the arrows that lead one down the hierarchy in the bookmarks
menu dissapear.  The folks at the mozillazine forums did extensive testing and
confirm this is an issue for the newer nightlies.

Reproducible: Always
Steps to Reproduce:
1.call the list-style image for .bookmark-item using -moz-image-region

Actual Results:  
the right menu arrows dissapear for the folder items in the bookmarks menu

Expected Results:  
displayed the right arrows as with other menu items

Comment 1

[PikeUK]

You might need to add some more information, a testcase or code sample before
this bug can be dealt with.

p.s. Have you seen Bug 220717 (-moz-image-region is now inherited, before it
wasn't), could that be an issue here? Perhaps you could take a look at the
bookmarks menu in DOM Inspector and see what the computed styles are set to and
where they are coming from.

Comment 2

[Kevin Davis]

Hmm... It seems that the bug was already registered:
http://bugzilla.mozilla.org/show_bug.cgi?id=231144

If I go into global/menu.css and specify the -moz-image-region as auto:

.menu-right {
  list-style-image: url("chrome://global/skin/menu/menu-arrow-disabled.gif");
  -moz-image-region: auto;
}

...the menu arrows return for any theme in which they previously dissapeared.
Without this code, however, they dissapear.  Does this help?

Comment 3

[PikeUK]

The global/menu.css in the default theme already contains -moz-image-region:
auto; in nightly builds, it was added in January:

http://bonsai.mozilla.org/cvsquery.cgi?dir=mozilla%2Ftoolkit&file=menu.css&date=explicit&mindate=2004-01-21&maxdate=2004-01-22

As I understand it (not particularly well I admit) whenever you use
list-style-image you should add a corresponding -moz-image-region as well since
you now can't guarantee that -moz-image-region won't have inherited a value from
somewhere else.

Anyway this bug should probably be closed since the nightlies already have this
line added and updating themes that need it is the responsibility of each author.

p.s. The only wierd thing is why this would affect 0.8, I thought that branched
in mid-December and this problem was introduced in January.

Comment 4

[PikeUK]

Based on comment 2 closing the bug as INVALID.

The new behaviour is deliberate after the changes made in Bug 220717 (that image
regions are now inherited). If they haven't already, some third party themes may
need to be updated to add -moz-image-region: auto where appropriate to reset the
image region.

Reporter (or anyone) please reopen if you disagree with this assessment.