239746 - All-day events should occupy multiple lines in a Week View.

Status: RESOLVED WORKSFORME

(Calendar :: Sunbird Only, enhancement)

Description

[Aleksey Nogin]

Currently, in the Week View, all the all-day events are pushed into a single
line, where there are no space for them. If you have a few of those every day,
then at most you will just see a bunch of stars...

I would proposed changing this to giving each all-day event a separate line.
Additionally, this line could _span_ several days in a multi-day all-day event,
which would make it even more readable.

Comment 1

[Mostafa Hosseini]

I think this issue is fixed in the to-be-checked-in patch for bug 236551

Comment 2

[Jussi Kukkonen]

(In reply to comment #1)
> I think this issue is fixed in the to-be-checked-in patch for bug 236551

Not really ( I didn't really change week view in that patch ), but it shouldn't
be a big change to make week view use the same event-arrangement functions - I
tried to keep week view in mind when creating them.

I'll look into it, but possibly after said checkin (to get some feedback first).

Comment 3

[Aleksey Nogin]

The new day view style for all-day events looks exactly right (IMHO), and if the
week view is updated in the same way (with multi-day events represented by a bar
spanning several days, as opposed to being repeated for each day, if possible),
I would be perfectly happy with it.

Comment 4

[Jussi Kukkonen]

Attachment: image of possible implementation

Here is something I'm working on (partly image manipulation at the moment).

Comment 5

[Aleksey Nogin]

Comment on attachment 146770 [details]
image of possible implementation

Very nice, this is exactly what I hoped for!

Comment 6

[Jussi Kukkonen]

Attachment: in preparation of the real patch...(checked in)

I moved the helper function 'setAllDayDrawProperties' from dayview.js to
calendarWindow.js, and modified it a little. It's now usable both in dayview
and weekview.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: fix strict warnings (checked in)

attachment 127717 [details] introduced a number of javascript strict warnings. This patch
fixes those. It is advisable to turn on strict warnings when hacking lots of
javascript, like calendar.

Comment 8

[Mostafa Hosseini]

Comment on attachment 148211 [details] [diff] [review]
fix strict warnings (checked in)

r=mostafah

Comment 9

[Aleksey Nogin]

BTW, a different RFE for the weekly view - bug 243494.

Comment 10

[Joey Minta]

*** Bug 309997 has been marked as a duplicate of this bug. ***

Comment 11

[Joey Minta]

This was fixed awhile ago in the new views.