239850 - drag and drop to a Bookmarks window might fail or be difficult if dropped below the end of list

Status: NEW

(SeaMonkey :: Bookmarks & History, defect)

Description

[Tom Hatta]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040316
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040316

When a bookmark is dropped below the last bookmark item in a list, the
insert-here caret won't appear and dropping the bookmark won't append it to the
end of the list. 

Reproducible: Always
Steps to Reproduce:
1. Open one or more Bookmarks windows or a Bookmark Manager windows by going to
"manage bookmarks" or "Open in New Window" from the context menu of any bookmark
folder.
2. Make a Bookmarks window tall enough so that the scollbar does not appear and
the window has enough space below the last bookmark item for drag and drop.
3. Drag and drop a bookmark item to that space.
Actual Results:  
The insert-here caret disappears when the mouse cursor is not immediately below
the last item. Dropping an item fails to insert an item. 

Expected Results:  
When dragging, the insert-here caret shows that the item will be inserted at the
end of the list. When dropping, the item will get inserted.

See also bug 127479: drag and drop to an empty Bookmarks window is impossible.

Comment 1

[Jesiah S]

I see this on LInux 2004051006 It seems like bug 127479 would cause this

Comment 2

[Wayne Mery (:wsmwk)]

> When a bookmark is dropped below the last bookmark item in a list, the
> insert-here caret won't appear and dropping the bookmark won't append it to the
> end of the list. 

It does work, but it's quirky, or at worst intermittent. 

If you drag the bookmark through other bookmarks in the list before you get to
the bottom, then you can drop it at the end of the list just fine.

If you first go well below the bottom, and move the mouse up, EVENTUALLY, you'll
get really, really close enough to the last bookmark and it WILL allow the
insertion. Tricky that.  

conclusion - is this a UI problem ?


Notes: 
* it doesn't happen in sidebar or dropping through the bookmark command menu -
however, in the sidebar there can be a delay of a few seconds before it will
allow the drop - I find this to be odd 
* this is not bug 127479

Comment 3

[Erik Staats]

The code that handles the drop logic for this case is in mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp nsTreeBodyFrame::HandleEvent.  If the drag coordinates are in the tree body frame but not in a row, the drag session canDrop attribute is set to false, preventing the drop action.

If nsTreeBodyFrame::ComputeDropPosition is changed to select dropAfter for the last row when the drag coordinates are in the tree body frame but not in a row, the drop action will drop after the last row.

Songbird has a similar bug for dropping items in playlist trees (http://bugzilla.songbirdnest.com/show_bug.cgi?id=4592).

Comment 4

[Phoenix]

Attachment: Screenshot of the problem

Looks like problem still here
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 SeaMonkey/2.15a1
Build identifier: 20120921003032