239942 - Mozilla doesn't support drop in encoder/decoders

Status: RESOLVED WONTFIX

(Core :: Internationalization, defect)

Description

[Mike Kaply [:mkaply]]

Currently if I create a new encoder/decoder in a DLL and drop it into
components, Mozilla won't recognize it because it requires an entry in
charsetAlias.properties.

My fix for this is in nsCharsetAliasImpl.cpp. If GetPreferred fails (we can't
find it in the properties file) we check to see if that encoding is registered
as a contract id. If it is, we let it pass as a character set.

This allows drop in encoder/decoders without changes to charsetAlias.properties.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Allow any encoder

This patch checks for an encoder if the value is not in the
charsetAlias.properties file by looking at the components that have been
registered.

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 145652 [details] [diff] [review]
Allow any encoder

r=smontagu, assuming that you actually need this :-)

Comment 3

[Masatoshi Kimura [:emk]]

Extentions can easily override charsetAlias.properties. For example, see Big5-HKSCS Patch.
https://addons.mozilla.org/firefox/addon/9294
Is this bug still valid?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Do we really want this? I don't think we should be encouraging even more encoding proliferation.

Comment 5

[Mike Kaply [:mkaply]]

Probably not anymore. Simon?

Comment 6

[Simon Montagu :smontagu]

Agreed