The default bug view has changed. See this FAQ.

NPStream's necko stream ownership and handling seems shady.

RESOLVED FIXED in mozilla15

Status

()

Core
Plug-ins
RESOLVED FIXED
13 years ago
5 years ago

People

(Reporter: jst, Assigned: Josh Aas)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
Seems like _destroystream() (in ns4xPlugin.cpp) should do more cleaning up of
the underlying necko streams than it does, like, closing it etc. And the
ownership of the underlying stream is far from obvious, and should be clarified
in the code.
QA Contact: plugins
(Assignee)

Updated

5 years ago
Assignee: peterlubczynski-bugs → joshmoz
(Assignee)

Comment 1

5 years ago
From related code comments the primary concern seems to be what we store for stream ndata. I'm working on that code now, taking this.
(Assignee)

Comment 2

5 years ago
Created attachment 625102 [details] [diff] [review]
fix v1.0

I didn't find any problems during my review of stream cleanup, but there are some things that can be more clear. This patch is largely improving comments, but it also does a little bit of re-organization and makes owning references more clear. It pushes necessary strong references further down in the stream cleanup process to make their necessity clearer.
Attachment #625102 - Flags: review?(benjamin)
(Assignee)

Comment 3

5 years ago
Try server run:

https://tbpl.mozilla.org/?tree=Try&rev=f4b4a651e203
(Reporter)

Updated

5 years ago
Attachment #625102 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

5 years ago
pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/407014e60866
https://hg.mozilla.org/mozilla-central/rev/407014e60866
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.