Custom install "Please select.." keyboard commands do not update Description

VERIFIED FIXED in mozilla1.8alpha1

Status

SeaMonkey
Installer
VERIFIED FIXED
14 years ago
13 years ago

People

(Reporter: benc, Assigned: Andrew Schultz)

Tracking

({access, verified1.7})

Trunk
mozilla1.8alpha1
x86
Linux
access, verified1.7
Bug Flags:
blocking1.7 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

929 bytes, patch
dveditz
: review+
Brian Ryner (not reading)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
STEPS:
Mozilla 1.6, Linux
Run installer, select "custom"
Looking at the custom installs, you can select a component by keyboard (up/down
arrows) or by mouse.

OBSERVED:
If you hilight a component, the description does not update unless you hit space
bar (which toggles the checkbox for installation).
(Assignee)

Comment 1

14 years ago
this is trivial to fix once bug 112252 lands
(although I'm not sure which trivial fix is best)

we can stop dropping keyboard events in RowSelected, or handle this case in
KeyPressed.  RowSelected seems better, but I'm not sure if other types of events
might trigger the case that gets dropped.

==> me
Assignee: general → ajschult
Depends on: 112252
Keywords: access
Target Milestone: --- → mozilla1.8alpha
(Assignee)

Comment 2

14 years ago
Created attachment 146249 [details] [diff] [review]
patch
(Assignee)

Updated

14 years ago
Attachment #146249 - Flags: review?(dveditz+bmo)
Comment on attachment 146249 [details] [diff] [review]
patch

r=dveditz
Attachment #146249 - Flags: review?(dveditz) → review+
(Assignee)

Updated

14 years ago
Attachment #146249 - Flags: superreview?(bryner)
Attachment #146249 - Flags: superreview?(bryner) → superreview+
(Assignee)

Comment 4

14 years ago
fixed
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

14 years ago
Any chance we can get a branch fix?
(Assignee)

Comment 6

14 years ago
the patch here would need to go on the branch along with the one from 112252. 
Neither have caused known regressions.  If you think this is sufficiently
important, request approval for the patch
(Reporter)

Comment 7

14 years ago
This doesn't have to block 1.7, but an eventual branch fix would be very nice.
Flags: blocking1.7?
(Reporter)

Comment 8

14 years ago
V/fixed, 5/11 daily, linux
Status: RESOLVED → VERIFIED

Comment 9

14 years ago
Comment on attachment 146249 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #146249 - Flags: approval1.7+

Comment 10

14 years ago
has this landed on the 1.7 branch yet? I don't see any checkins referencing this
bug. 
Flags: blocking1.7? → blocking1.7-
checked in on 1.7 branch
Keywords: fixed1.7
(Reporter)

Comment 12

14 years ago
I got email from a branch user saying this is fixed.
Keywords: fixed1.7 → verified1.7
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.