Closed Bug 240212 Opened 20 years ago Closed 20 years ago

Custom install "Please select.." keyboard commands do not update Description

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.8alpha1

People

(Reporter: benc, Assigned: ajschult784)

References

Details

(Keywords: access, verified1.7)

Attachments

(1 file)

patch
929 bytes, patch
dveditz
: review+
bryner
: superreview+
asa
: approval1.7+
Details | Diff | Splinter Review 
STEPS:
Mozilla 1.6, Linux
Run installer, select "custom"
Looking at the custom installs, you can select a component by keyboard (up/down
arrows) or by mouse.

OBSERVED:
If you hilight a component, the description does not update unless you hit space
bar (which toggles the checkbox for installation).
this is trivial to fix once bug 112252 lands
(although I'm not sure which trivial fix is best)

we can stop dropping keyboard events in RowSelected, or handle this case in
KeyPressed.  RowSelected seems better, but I'm not sure if other types of events
might trigger the case that gets dropped.

==> me
Assignee: general → ajschult
Depends on: 112252
Keywords: access
Target Milestone: --- → mozilla1.8alpha
Attached patch patch — — Splinter Review 

    
  

        Attachment #146249 -
        Flags: review?(dveditz+bmo)

    
    

    
  
Comment on attachment 146249 [details] [diff] [review]
patch

r=dveditz

        Attachment #146249 -
        Flags: review?(dveditz) → review+

    
  

        Attachment #146249 -
        Flags: superreview?(bryner)

        Attachment #146249 -
        Flags: superreview?(bryner) → superreview+

    
    

    
  
fixed
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

    
    

    
  
Any chance we can get a branch fix?

    
    

    
  
the patch here would need to go on the branch along with the one from 112252. 
Neither have caused known regressions.  If you think this is sufficiently
important, request approval for the patch

    
    

    
  
This doesn't have to block 1.7, but an eventual branch fix would be very nice.
Flags: blocking1.7?

    
    

    
  
V/fixed, 5/11 daily, linux
Status: RESOLVED → VERIFIED

    
    

    
  
Comment on attachment 146249 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.7

        Attachment #146249 -
        Flags: approval1.7+

    
    

    
  
has this landed on the 1.7 branch yet? I don't see any checkins referencing this
bug. 
Flags: blocking1.7? → blocking1.7-

    
    

    
  
checked in on 1.7 branch
Keywords: fixed1.7

    
    

    
  
I got email from a branch user saying this is fixed.
Keywords: fixed1.7 → verified1.7
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: