24027 - Charset Menu <Static> area: read from prefs and have editing UI

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[cata]

There are two things to be done here:
a) The menu items should be read from preferences
b) We need an UI to edit those preferences

Comment 1

[cata]

The first part is done. The static area of the charset menu is being read from 
the prefs. It looks like:

pref("intl.charset_menu.static", "iso-8859-1, iso-2022-jp");

Now we need an UI to edit these prefs. Matt, I am reassigning this bug to you 
because I need your attention and help here. Just some pointers/examples & an 
entry point should suffice, I can do the rest of the work myself. You can 
reassign the bug back to me after you put me on the right track. Thanks!

Th UI I need should allow me to build the list of charsets from the available 
ones.

Comment 2

[cata]

The code I was talking about will be in the tree this afternoon.

Comment 3

[Teruko Kobayashi]

Added beta1 because this is beta criteria.

Comment 4

[Phil Peterson]

PDT+

Comment 5

[matt]

Sorry just saw this bug.
here is the best example for you
http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/con
tent/pref-fonts.js
http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/con
tent/pref-fonts.xul
This is using the font enumerator.
Any form that uses the prefs panel
initialization will get read into the forms automatically.

Make a form
These are the entries:
pref= true if it is a pref
preftype = either int or string or bool
prefindex = this is used for radio buttons
prefstring = this is the js pref
If you need more help ask please

Comment 6

[bobj]

Matt,
I don't think the font prefs is a good example for charset menu customization.

It needs something along the lines of the sidebar customization that has a
Add/Remove GUI.  See the spec:
  http://www.mozilla.org/projects/intl/uidocs/browsercharmenu.html
Look under the bullet "Customize ... Preference Dialogs".

So is this a better example for what is needed?
http://lxr.mozilla.org/seamonkey/source/xpfe/components/sidebar/resources/custom
ize-panel.xul
http://lxr.mozilla.org/seamonkey/source/xpfe/components/sidebar/resources/custom
ize-panel.js

Comment 7

[bobj]

Reassigned to jbetak.
jbetak, Please update ETA if necessary.

Comment 8

[bobj]

jbetak,
If you need help, the expert on this GUI stuff is matt.
Also tao played with some stuff a while ago and may be able to help too.

Comment 9

[bobj]

Do you have the IDL interface to get the list of charsets and the corresponding
UI names?

Comment 10

[[e-mail] (away - not reading bugmail)]

Bob,

no not yet - I'm sure Cata has finished working on it. I have the UI and the 
underlying JavaScript logic ready to go. I also can write out the composite 
string containing the selected charsets to virtually any preference, except 
intl.charset_menu.static. 

I might need to ask Cata to have a look at it, seems to be very specific to this 
preference .



Do you have the IDL interface to get the list of charsets and the corresponding
UI names?

Comment 11

[[e-mail] (away - not reading bugmail)]

Incorporated changes suggested by bobj on Feb 18, ready to check-in...

Comment 12

[cata]

As I was saying, the new interface (IDL file and its implementation) are ready, 
reviewed & tested. As I have Bob's permission, I'll check in ASAP.

Juraj, after you have your preference editing UI in, please assign this bug to 
me: listen at runtime to preference change and rebuild static area of charset 
menu when it happens.

Comment 13

[cata]

Ok, my part is in.

Comment 14

[[e-mail] (away - not reading bugmail)]

It´s in! Cata - as requested sending over to you for the runtime to preference change and rebuild static area of charset 
menu.

Comment 15

[bobj]

Cata, Please update the ETA.

Comment 16

[bobj]

We have what we need for Beta1.
I opened bug 28983 for the remaining work to make this dynamic.

Comment 17

[bobj]

bugzilla forces me to add a comment when I resolve this...
see above comment...

Comment 18

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 19

[Allan Masri]

with build of 2/29/2000, ID 2000022708:
Most of this works, but there are still some problems.
1) Juraj finds that selected fonts are not displayed in View|Character
coding|Customize screen--should be displayed in right-hand list
2) I find that Big5 charset can't be saved. I can select it, but when I restart,
it is not in the View | Character coding submenu nor in the Customize panel's
right-hand list.

Comment 20

[[e-mail] (away - not reading bugmail)]

Hi Alan,

I'm closing this bug again - the Big5 was a very good catch. I had some code 
from the early development stages that didn't handle short pref IDs (e.g. big5) 
all that well.

The other problem was caused by some new decoders without a title/lable. I 
beefed upp the error handling in the Init() function to make sure JS doesn't 
stop interpreting if something similar happened again...

Comment 21

[Allan Masri]

verified in 3/1/2000 build

Comment 22

[bobj]

On Win95, not all the corresponding fonts are shown in the drop down.  I did
not carefully inspect anything but the "Western fonts".  Below is my comparison
of what is shown in the 3/3 build vs. IE5.

Seamonkey "Western:Serif:"

Bitstream CyberCJK
Bitstream Cyberbit
Bookman Old Style
Garamond
Times New Roman

Seamonkey Western:Monospace:
Courier New
OCR B MT
OCR-A
QuickType Mono
r_ansi

By comparison here is what IE5 shows.

IE5 "Latin based: Web page font:"
Arial
Arial Black
Arial Narrow
Bitstream Cyberbit
Bitstream Cyberbit
Bookman Old Style
Comic Sans MS
Courier New
Garamond
Impact
OCR B MT
OCR-A
QuickType
QuickType Condensed
QuickType Mono
QuickType Pi
r_ansi
Tahoma
Times New Roman

IE5 "Latin based: Plain text font:"
Courier New
OCR B MT
OCR-A
QuickType Mono
r_ansi

Comment 23

[bobj]

Whoops.  Commented on the wrong bug!

Comment 24

[bobj]

Re-opened wrong bug.  Restoring this bug to FIXED/VERIFED...