Closed Bug 240291 Opened 20 years ago Closed 20 years ago
Block Frame::Add Frames should handle <br> better
See bug 237735 comment 4 and bug 237735 comment 6. Basically, we should try to create new lines at <br> during frame insertion to minimize the O(N^2) nature of inserting frames a bit at a time.
This makes the testcase in bug 237735 run about 3 times faster... and I think it shouldn't affect normal browsing much.
Comment on attachment 145915 [details] [diff] [review] Proposed patch Could this be approved for 1.7, please? It's quite safe (since reflow will end up moving lines about anyway and ensuring that <br>s end lines), and improves the performance of assigning large chunks of text to a textarea significantly.
Attachment #145915 - Flags: approval1.7?
Summary: nsBlockFrame::AddFrames should handle <br> better → [FIXr]nsBlockFrame::AddFrames should handle <br> better
Comment on attachment 145915 [details] [diff] [review] Proposed patch a=asa (on behalf of drivers) for checkin to 1.7
Attachment #145915 - Flags: approval1.7? → approval1.7+
Checked in for 1.8a; leaving open pending 1.7 checkin.
Checked in to 1.7 branch.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.