240340 - Key events broken in plugins on MacOSX

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Johnny Stenback (:jst)]

Bug 233142 regressed key events (among other events, see bug 238449) in plugins,
especially on Mac OSX. The old assumption that returning an error code from
event code prevented the events default action is no longer true, most of the
plugin frame code played nice, but not all of it.

Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: PreventDefault() where needed, and no more bogus error returns

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 145956 [details] [diff] [review]
PreventDefault() where needed, and no more bogus error returns

Requesting approval for this plugin event regression.

Comment 3

[Johnny Stenback (:jst)]

Fix checked in on the trunk.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 145956 [details] [diff] [review]
PreventDefault() where needed, and no more bogus error returns

a=asa (on behalf of drivers) for checkin to 1.7

Comment 5

[Johnny Stenback (:jst)]

Fixed on the 1.7 branch now too!