240363 - autoscroll should stop completely when window loses focus

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[pantsgolem]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040406 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040406 Firefox/0.8.0+

Currently, if Firefox is autoscrolling when the window loses focus, autoscroll
does not stop.  While this is generally not an issue when the user changes the
focused window, it can cause problems when another window steals the focus.

Reproducible: Always
Steps to Reproduce:
1. Middle-click and mouse up/down to start autoscrolling (enable autoscroll if
it's not already enabled)
2. Switch to another window without clicking anywhere in Firefox
3. Switch back to Firefox again without clicking in the window itself
Actual Results:  
Firefox keeps happily scrolling along.

Expected Results:  
Autoscroll should stop as soon as the Firefox window loses focus.

I'm using KDE 3.2, in case it handles window focusing any differently than other
window managers.

Comment 1

[Martijn Wargers (dead)]

See also bug 213496 which is somewhat related.
Autoscroll should probably stop working on any other event than mousemove, which
is basically the case in Internet Explorer

Comment 2

[Robert Parenton]

Confirmed.  Also occurs on an Alt+Tab task switch.

Comment 3

[Robert Parenton]

*** Bug 254806 has been marked as a duplicate of this bug. ***

Comment 4

[Steve England [:stevee]]

*** Bug 295541 has been marked as a duplicate of this bug. ***

Comment 5

[Asaf Romano (gone)]

Attachment: patch

This actually fixes a few more cases (In particular, focusing something else in the chrome window or another document in this.contentWindow)

Comment 6

[Asaf Romano (gone)]

I will write a unit test once we have a the necessary framework in-place.

Comment 7

[Asaf Romano (gone)]

mozilla/toolkit/content/widgets/browser.xml 1.101