Closed Bug 240367 Opened 20 years ago Closed 20 years ago

Saving page (Save Page As) or image results in "Download Error" dialog with hostname (but succeeds anyway) download error

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.7final

People

(Reporter: jruderman, Assigned: Biesinger)

References

Details

(Keywords: regression, smoketest, verified1.7)

Attachments

(1 file)

patch
1.59 KB, patch
darin.moz
: review+
darin.moz
: superreview+
mkaply
: approval1.7+
Details | Diff | Splinter Review 
Steps to reproduce:
1. Go to http://www.google.com/
2. Right-click the logo and select "Save Image As..."
3. Select a download location.

Result: Dialog that says "Download Error" in the title and "www.google.com" in
the body.  (The download succeeds despite the error message.)

Based on when reports started, I think this is a regression starting in April 11
builds.
Flags: blocking0.9?
This started with me as well when I upgraded to Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.7b) Gecko/20040411 Firefox/0.8.0+
Flags: blocking0.9? → blocking0.9+
This bug also affects Linux (2004-04-11) builds. --> All/All.

camecek, do not set the blocking0.9+ or blocking0.9- flag unless you have direct
permission from a Firefox developer to so, and if so, you need to state this. Am
setting back to blocking0.9?, even though this is almost certainly a + anyway.

Also setting severity to major, as this is a highly visible bug.
Severity: normal → major
Flags: blocking0.9+ → blocking0.9?
Keywords: smoketest
OS: Windows XP → All
Hardware: PC → All
Darin, comment 3 says this regression is a side effect of your checkin.
Confirmed.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040414
Firefox/0.8.0+
Microsoft Windows 2000 Pro 5.00.2195 SP4
well, this happens in seamonkey as well; it's just that the error dialog in
seamonkey doesn't look like one...

(It shows with a title of "Saving <filename>", and the dialog text is the filename)

-> browser/networking per comment 3
Assignee: bugs → darin
Component: Downloading → Networking
Product: Firefox → Browser
QA Contact: aebrahim → benc
Version: unspecified → Trunk
(In reply to comment #6)
> (It shows with a title of "Saving <filename>", and the dialog text is the
filename)

sorry, the text is actually the hostname
so the problem is (for the seamonkey progress dialog, at least):
the onStatusChange function gets an aStatus code of 2152398856, i.e. 0x804B0008,
i.e. nsITransport::STATUS_READING.
That is an error code.

This seems to only happen for cached loads; i.e. almost always for "Save image"
and "File|save page", less often for "save link target".

of course, before bug 240053's patch, cached loads did not generate such
progress events at all. but the question is, why was this not a problem with
non-cached loads before?

(nsIWebProgressListener leaves aStatus totally undocumented of course, which
doesn't help...)
*** Bug 240514 has been marked as a duplicate of this bug. ***
Flags: blocking1.7?
*** Bug 240612 has been marked as a duplicate of this bug. ***
If a larger image (e.g. http://pubs.usgs.gov/imap/i-2812/i-2812.jpg 1.5Mb) is
saved the warning keep coming, at least 20 in total. Clearing Cache before
download prevents these problems and insure a "normal" download dialogue w/o any
errors.
*** Bug 240959 has been marked as a duplicate of this bug. ***
*** Bug 241008 has been marked as a duplicate of this bug. ***
*** Bug 241007 has been marked as a duplicate of this bug. ***
*** Bug 241091 has been marked as a duplicate of this bug. ***
(In reply to comment #8)
> but the question is, why was this not a problem with
> non-cached loads before?

...because webbrowserpersist filters those out. duh.
Attached patch patch — — Splinter Review 
Assignee: darin → cbiesinger
Status: NEW → ASSIGNED

        Attachment #146721 -
        Flags: superreview?(darin)

        Attachment #146721 -
        Flags: review?(darin)
Target Milestone: --- → mozilla1.7final

    
    

    
  
I can confirm that the patch fixes this bug...now all we need is r= and sr=

    
    

    
  
*** Bug 241321 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241397 has been marked as a duplicate of this bug. ***

    
    

    
  
Darin should be back tomorrow to look at this.

He had a family emergency.
Flags: blocking1.7? → blocking1.7+

    
    

    
  
*** Bug 241406 has been marked as a duplicate of this bug. ***

    
    

    
  
The alerts I get on OS/2 since 11 April are not "errors", just URL saved
announcements. Save image as gives the alert on top of the normal dialog. When
the alert is dismissed, the dialog remains until dismissed separately. In
contrast, save page as alert dismissal dismisses the dialog as well. I use the
XFile filepicker replacement.

    
    

    
  
*** Bug 241449 has been marked as a duplicate of this bug. ***

    
    

    
  
Comment on attachment 146721 [details] [diff] [review]
patch

thanks biesi!!

        Attachment #146721 -
        Flags: superreview?(darin)

        Attachment #146721 -
        Flags: superreview+

        Attachment #146721 -
        Flags: review?(darin)

        Attachment #146721 -
        Flags: review+

    
    

    
  
Comment on attachment 146721 [details] [diff] [review]
patch

low risk patch to fix an error dialog appearing when saving a page/image from
cache

        Attachment #146721 -
        Flags: approval1.7?

    
    

    
  
checked in on trunk

    
    

    
  
Comment on attachment 146721 [details] [diff] [review]
patch

a=mkaply

        Attachment #146721 -
        Flags: approval1.7? → approval1.7+

    
    

    
  
(In reply to comment #27)
> checked in on trunk
will it be checked into the 1.7 branch as well?



    
    

    
  
(In reply to comment #29)
> will it be checked into the 1.7 branch as well?

Sure, I've just done that - I was waiting for approval (that mkaply just gave)

Checking in nsWebBrowserPersist.cpp;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp,v
 <--  nsWebBrowserPersist.cpp
new revision: 1.89.2.1; previous revision: 1.89
done

Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Keywords: fixed1.7
Resolution: --- → FIXED

    
    

    
  
*** Bug 241536 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241541 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241544 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241569 has been marked as a duplicate of this bug. ***

    
    

    
  
Using branch build from 20040424, patch is great, nothing seems to be broken as
a result of this patch, everything perfect here.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040424
Firefox/0.8.0+

    
    

    
  
*** Bug 241620 has been marked as a duplicate of this bug. ***

    
    

    
  
Also verified fixed on the trunk.
Status: RESOLVED → VERIFIED

    
    

    
  
now that this is _verified_ fixed it no longer shows up in the standard mostfreq
report, so we can expect even more dupes :-(

    
    

    
  
*** Bug 241636 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241666 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241692 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241714 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241721 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241772 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241786 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241807 has been marked as a duplicate of this bug. ***
Flags: blocking0.9?

    
    

    
  
*** Bug 241898 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241917 has been marked as a duplicate of this bug. ***

    
    

    
  
(In reply to comment #48)
> *** Bug 241917 has been marked as a duplicate of this bug. ***

Sorry for the dupe. The standard search on the bugzilla starting page with
"Download Error" as the text *does not* find this one. I guess mine will not be
the last dupe :-(


    
    

    
  
(In reply to comment #49)
> Sorry for the dupe. The standard search on the bugzilla starting page with
> "Download Error" as the text *does not* find this one. I guess mine will not be
> the last dupe :-(

That's because this bug is fixed. What you call "standard search" only searches
unresolved bugs because these are of most interest of developers. So before
filing a bug you should also include RESOLVED bugs in your search. 

Moreover, since this bug is already fixed in recent builds, the number of users
encountering this problem will drops and therefore the number of duplicate
reports will drop.



    
    

    
  
The number of dupes will not fade significantly until next release candidate.

    
    

    
  
(In reply to comment #51)
> The number of dupes will not fade significantly until next release candidate.

Sorry for the spam. My comment 50 was intended for all those people who filed a
dupe even after searching Bugzilla. Hopefully this will lead them to understand
the queries in Bugzilla a bit better and therefore avoid dupes from those people
in the future. 

As to dupes to this particular issue: not much we can do about until 1.7RC2
comes out [planned for May 7]. The number of dupes for this issue will then
drop. And it will drop because 1) the peak of RC1 downloads is probably already
past and 2) the issue is fixed. 

But spamming many users with speculations on the projected number of bugs is not
done. Therefore, once more:comment 50 was intended to "educate" bugzilla users.

    
  
Summary: Saving page or image results in "Download Error" dialog (but succeeds anyway) → Saving page or image results in "Download Error" dialog (but succeeds anyway) download error

    
    

    
  
*** Bug 241976 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 241994 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242025 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242057 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242074 has been marked as a duplicate of this bug. ***

    
    

    
  
(In reply to comment #50)
> (In reply to comment #49)
> > Sorry for the dupe. The standard search on the bugzilla starting page with
> > "Download Error" as the text *does not* find this one. I guess mine will not be
> > the last dupe :-(
> 
> That's because this bug is fixed. What you call "standard search" only searches
> unresolved bugs because these are of most interest of developers. So before
> filing a bug you should also include RESOLVED bugs in your search. 
> 
> Moreover, since this bug is already fixed in recent builds, the number of users
> encountering this problem will drops and therefore the number of duplicate
> reports will drop.
> 
> 

when you go to the "enter a (new) bug" page, for example:  
http://bugzilla.mozilla.org/enter_bug.cgi?product=Browser  
the "Step 1 - search for your bug" section has a box to enter 
your search terms. there is NO place to check resolved or unresolved or any of
that. just put in text, then click the "search" button. this "Step 1 search"
button action should include resolved as a DEFAULT behaviour! it does not. those
of us entering new bugs do not even know HOW to include resolved, LET ALONE that
we even need to include it. if the bugzilla managers change the default "Step 1
- search for your bug" action to include resolved, then the bugzilla managers
will spend less time wasted on marking duplicates  :)   invest a little time now
changing the search behaviour, save a lot of time in long run that more than
makes up for it...


    
    

    
  
*** Bug 242096 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242138 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242154 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242246 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242262 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242271 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242312 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242335 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242332 has been marked as a duplicate of this bug. ***

    
    

    
  
Adding "Save Page As" (actual UI element) and "with hostname" (actual error) to
the subject to make this bug easier to find.
Summary: Saving page or image results in "Download Error" dialog (but succeeds anyway) download error → Saving page (Save Page As) or image results in "Download Error" dialog with hostname (but succeeds anyway) download error

    
    

    
  
*** Bug 242358 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242403 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242403 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242415 has been marked as a duplicate of this bug. ***

    
    

    
  
james@nervousness.org do NOT REMOVE members from the CC list unless
specificially ASKED by those people. Furthermore, do NOT remove all these names
w/o any comment or justification whatsoever

I'm putting you on the CC list so you get this message.

    
    

    
  
James: Any particular reason that you removed all those addresses (including
mine) from the CC list?

    
    

    
  
he was probably using netscape 4 and ran into a bug of that browser.

    
    

    
  
*** Bug 242523 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242555 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242559 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242593 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242802 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 242910 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243000 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243039 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243043 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243058 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243094 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243140 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243247 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243287 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243427 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243590 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243641 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243772 has been marked as a duplicate of this bug. ***

    
    

    
  
Bug 243772 is not exactly a duplicate of the bug described in the Summary.
My dialog does not say any kind of error, it only shows the yellow
warning symbol.


    
    

    
  
*** Bug 243830 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 243877 has been marked as a duplicate of this bug. ***

    
    

    
  
(In reply to comment #94)
> Bug 243772 is not exactly a duplicate of the bug described in the Summary.
> My dialog does not say any kind of error, it only shows the yellow
> warning symbol.

FYI, since the Mac uses a sheet and there's no window title on the sheet,
there's no error message (the error is in the window title on other platforms).


    
    

    
  
*** Bug 243987 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 245166 has been marked as a duplicate of this bug. ***
Keywords: fixed1.7 → verified1.7

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: