If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

js_DecompileValueGenerator doesn't take a JSBool

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

While passing JS_FALSE does work (since it is equivalent to 0 and currently
translates to JSDVG_IGNORE_STACK), passing it here is not really cool, and
momentarily confusing to the reader (in this case, me).
Created attachment 146068 [details] [diff] [review]
proposed patch
Fixed.

/be
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Comment on attachment 146068 [details] [diff] [review]
proposed patch

Brendan, this looks to be your code.  Could you have a look and -- since I
don't believe I have access to this partition -- commit?
Attachment #146068 - Flags: superreview?(brendan)
Attachment #146068 - Flags: review?(brendan)
Comment on attachment 146068 [details] [diff] [review]
proposed patch

You're too fast for me, brendan.  ;-)
Attachment #146068 - Flags: superreview?(brendan)
Attachment #146068 - Flags: review?(brendan)
You need to log in before you can comment on or make changes to this bug.