Closed Bug 240458 Opened 21 years ago Closed 21 years ago

js_DecompileValueGenerator doesn't take a JSBool

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: caillon, Assigned: caillon)

Details

Attachments

(1 file)

While passing JS_FALSE does work (since it is equivalent to 0 and currently
translates to JSDVG_IGNORE_STACK), passing it here is not really cool, and
momentarily confusing to the reader (in this case, me).
Fixed.

/be
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment on attachment 146068 [details] [diff] [review]
proposed patch

Brendan, this looks to be your code.  Could you have a look and -- since I
don't believe I have access to this partition -- commit?
Attachment #146068 - Flags: superreview?(brendan)
Attachment #146068 - Flags: review?(brendan)
Comment on attachment 146068 [details] [diff] [review]
proposed patch

You're too fast for me, brendan.  ;-)
Attachment #146068 - Flags: superreview?(brendan)
Attachment #146068 - Flags: review?(brendan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: